2023-09-29 17:46:03

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH V2 0/2] Add partial initialization support

On 29/09/2023 11:28, Sarthak Garg wrote:
> Add the ability to partially initialize the MMC device by
> using device sleep/awake sequence (CMD5).
> Device will be sent to sleep state during mmc runtime/system suspend
> and will be woken up during mmc runtime/system resume.
> By using this sequence the device doesn't need full initialization
> which gives 25% time reduction in system/runtime resume path.
> Also enable this feature for qualcomm controllers.
>
> Sarthak Garg (2):
> mmc: core: Add partial initialization support
> mmc: sdhci-msm: Enable MMC_CAP2_SLEEP_AWAKE for Qualcomm controllers
>
> drivers/mmc/core/mmc.c | 162 +++++++++++++++++++++++++++++++++--
> drivers/mmc/host/sdhci-msm.c | 1 +
> include/linux/mmc/card.h | 4 +
> include/linux/mmc/host.h | 2 +
> 4 files changed, 160 insertions(+), 9 deletions(-)
>
> --
> 2.17.1
>

A terrible nit pick on my part however, you should include the name of
the subsystem/driver in the title of the series.

"mmc: Do this awesome new thing"

---
bod


2023-10-04 10:58:45

by Sarthak Garg

[permalink] [raw]
Subject: Re: [PATCH V2 0/2] Add partial initialization support


On 9/29/2023 6:38 PM, Bryan O'Donoghue wrote:
> On 29/09/2023 11:28, Sarthak Garg wrote:
>> Add the ability to partially initialize the MMC device by
>> using device sleep/awake sequence (CMD5).
>> Device will be sent to sleep state during mmc runtime/system suspend
>> and will be woken up during mmc runtime/system resume.
>> By using this sequence the device doesn't need full initialization
>> which gives 25% time reduction in system/runtime resume path.
>> Also enable this feature for qualcomm controllers.
>>
>> Sarthak Garg (2):
>>    mmc: core: Add partial initialization support
>>    mmc: sdhci-msm: Enable MMC_CAP2_SLEEP_AWAKE for Qualcomm controllers
>>
>>   drivers/mmc/core/mmc.c       | 162 +++++++++++++++++++++++++++++++++--
>>   drivers/mmc/host/sdhci-msm.c |   1 +
>>   include/linux/mmc/card.h     |   4 +
>>   include/linux/mmc/host.h     |   2 +
>>   4 files changed, 160 insertions(+), 9 deletions(-)
>>
>> --
>> 2.17.1
>>
>
> A terrible nit pick on my part however, you should include the name of
> the subsystem/driver in the title of the series.
>
> "mmc: Do this awesome new thing"
>
> ---
> bod


Thanks for the comment will take care in V3.

Thanks,
Sarthak