2021-10-21 12:38:16

by Jiabing Wan

Subject: [PATCH] selftests: vm: Remove duplicated include in hugepage-mremap

Fix following checkinclude.pl warning:
./tools/testing/selftests/vm/hugepage-mremap.c: fcntl.h is included
more than once.

Signed-off-by: Wan Jiabing <[email protected]>
---
tools/testing/selftests/vm/hugepage-mremap.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/vm/hugepage-mremap.c b/tools/testing/selftests/vm/hugepage-mremap.c
index 8bc117b12f78..257df94697a5 100644
--- a/tools/testing/selftests/vm/hugepage-mremap.c
+++ b/tools/testing/selftests/vm/hugepage-mremap.c
@@ -12,7 +12,6 @@
#include <stdio.h>
#include <unistd.h>
#include <sys/mman.h>
-#include <fcntl.h>
#include <errno.h>
#include <fcntl.h> /* Definition of O_* constants */
#include <sys/syscall.h> /* Definition of SYS_* constants */
--
2.20.1

2021-10-22 12:20:02

by David Hildenbrand

Subject: Re: [PATCH] selftests: vm: Remove duplicated include in hugepage-mremap

On 21.10.21 14:29, Wan Jiabing wrote:
> Fix following checkinclude.pl warning:
> ./tools/testing/selftests/vm/hugepage-mremap.c: fcntl.h is included
> more than once.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> tools/testing/selftests/vm/hugepage-mremap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/vm/hugepage-mremap.c b/tools/testing/selftests/vm/hugepage-mremap.c
> index 8bc117b12f78..257df94697a5 100644
> --- a/tools/testing/selftests/vm/hugepage-mremap.c
> +++ b/tools/testing/selftests/vm/hugepage-mremap.c
> @@ -12,7 +12,6 @@
> #include <stdio.h>
> #include <unistd.h>
> #include <sys/mman.h>
> -#include <fcntl.h>
> #include <errno.h>
> #include <fcntl.h> /* Definition of O_* constants */
> #include <sys/syscall.h> /* Definition of SYS_* constants */
>

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb