2020-11-02 19:16:19

by Faiz Abbas

[permalink] [raw]
Subject: [PATCH 0/3] Add gpio support for TI's J7200 platform

The following patches add gpio support for TI's J7200 platform.

These patches were posted as a part of an older series but have now
been split into three parts. The 3 parts add configs, gpios and MMC/SD
related dts patches respectively.

Older series is here:
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Series adding configs to arm64 defconfig is here:
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Faiz Abbas (3):
arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
modules

.../dts/ti/k3-j7200-common-proc-board.dts | 16 +++++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 68 +++++++++++++++++++
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 32 +++++++++
3 files changed, 116 insertions(+)

--
2.17.1


2020-11-04 11:42:44

by Lokesh Vutla

[permalink] [raw]
Subject: Re: [PATCH 0/3] Add gpio support for TI's J7200 platform



On 03/11/20 12:41 am, Faiz Abbas wrote:
> The following patches add gpio support for TI's J7200 platform.
>
> These patches were posted as a part of an older series but have now
> been split into three parts. The 3 parts add configs, gpios and MMC/SD
> related dts patches respectively.

Series looks good to me.

Reviewed-by: Lokesh Vutla <[email protected]>

Thanks and regards,
Lokesh

2020-11-12 16:44:38

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 0/3] Add gpio support for TI's J7200 platform

On 00:41-20201103, Faiz Abbas wrote:
> The following patches add gpio support for TI's J7200 platform.
>
> These patches were posted as a part of an older series but have now
> been split into three parts. The 3 parts add configs, gpios and MMC/SD
> related dts patches respectively.
>
> Older series is here:
> https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> Series adding configs to arm64 defconfig is here:
> https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> Faiz Abbas (3):
> arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
> arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain

I am not sure why we are splitting patches per domain here. We
should just have a single patch that introduces the nodes, I dont see a
specific benefit. In addition, series also introduces additional
Missing #address-cells in interrupt provider

Which we need a conclusion for and the comments already provided.


--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D