2023-06-02 01:36:36

by John Hubbard

Subject: [PATCH 08/12] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h

This fixes a real bug, too, because xstate_size() was assuming that
the stack variable xstate_size was initialized to zero. That's not
guaranteed nor even especially likely.

Signed-off-by: John Hubbard <[email protected]>
---
tools/testing/selftests/mm/pkey-x86.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftests/mm/pkey-x86.h
index 72c14cd3ddc7..e32ae8a1cd99 100644
--- a/tools/testing/selftests/mm/pkey-x86.h
+++ b/tools/testing/selftests/mm/pkey-x86.h
@@ -132,7 +132,7 @@ int pkey_reg_xstate_offset(void)
unsigned int ecx;
unsigned int edx;
int xstate_offset;
- int xstate_size;
+ int xstate_size = 0;
unsigned long XSTATE_CPUID = 0xd;
int leaf;

--
2.40.1

2023-06-02 10:34:33

by David Hildenbrand

Subject: Re: [PATCH 08/12] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h

On 02.06.23 03:33, John Hubbard wrote:
> This fixes a real bug, too, because xstate_size() was assuming that
> the stack variable xstate_size was initialized to zero. That's not
> guaranteed nor even especially likely.
>
> Signed-off-by: John Hubbard <[email protected]>

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb