2021-10-26 10:00:26

by Borislav Petkov

[permalink] [raw]
Subject: Re: vmlinux.o: warning: objtool: do_machine_check()+0x5fa: call to memset() leaves .noinstr.text section

Hi,

On Tue, Oct 26, 2021 at 04:16:21PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
> commit: 7bb39313cd6239e7eb95198950a02b4ad2a08316 x86/mce: Make mce_timed_out() identify holdout CPUs
> date: 10 months ago
> config: x86_64-buildonly-randconfig-r006-20211022 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7bb39313cd6239e7eb95198950a02b4ad2a08316
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 7bb39313cd6239e7eb95198950a02b4ad2a08316
> # save the attached .config to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All warnings (new ones prefixed by >>):
>
>>> vmlinux.o: warning: objtool: do_machine_check()+0x5fa: call to memset() leaves .noinstr.text section

if you have the technical capability to ignore all noinstr warnings
coming from the mce code, please do so.

I have a patchset to address that but more important work preempts me
constantly from cleaning it up and sending it out properly. ;-\

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg


2021-10-27 20:37:51

by Chen, Rong A

[permalink] [raw]
Subject: Re: [kbuild-all] Re: vmlinux.o: warning: objtool: do_machine_check()+0x5fa: call to memset() leaves .noinstr.text section



On 10/26/2021 4:23 PM, Borislav Petkov wrote:
> Hi,
>
> On Tue, Oct 26, 2021 at 04:16:21PM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
>> commit: 7bb39313cd6239e7eb95198950a02b4ad2a08316 x86/mce: Make mce_timed_out() identify holdout CPUs
>> date: 10 months ago
>> config: x86_64-buildonly-randconfig-r006-20211022 (attached as .config)
>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>> reproduce (this is a W=1 build):
>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7bb39313cd6239e7eb95198950a02b4ad2a08316
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git fetch --no-tags linus master
>> git checkout 7bb39313cd6239e7eb95198950a02b4ad2a08316
>> # save the attached .config to linux build tree
>> mkdir build_dir
>> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> vmlinux.o: warning: objtool: do_machine_check()+0x5fa: call to memset() leaves .noinstr.text section
>
> if you have the technical capability to ignore all noinstr warnings
> coming from the mce code, please do so.
>
> I have a patchset to address that but more important work preempts me
> constantly from cleaning it up and sending it out properly. ;-\
>

Hi Borislav,

Thanks for the feedback, We have ignored these warnings from mce.

Best Regards,
Rong Chen

2022-01-21 19:56:33

by Jakub Kicinski

[permalink] [raw]
Subject: Re: vmlinux.o: warning: objtool: do_machine_check()+0x5fa: call to memset() leaves .noinstr.text section

On Tue, 26 Oct 2021 10:23:30 +0200 Borislav Petkov wrote:
> On Tue, Oct 26, 2021 at 04:16:21PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
> > commit: 7bb39313cd6239e7eb95198950a02b4ad2a08316 x86/mce: Make mce_timed_out() identify holdout CPUs
> > date: 10 months ago
> > config: x86_64-buildonly-randconfig-r006-20211022 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > reproduce (this is a W=1 build):
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7bb39313cd6239e7eb95198950a02b4ad2a08316
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout 7bb39313cd6239e7eb95198950a02b4ad2a08316
> > # save the attached .config to linux build tree
> > mkdir build_dir
> > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All warnings (new ones prefixed by >>):
>
> if you have the technical capability to ignore all noinstr warnings
> coming from the mce code, please do so.
>
> I have a patchset to address that but more important work preempts me
> constantly from cleaning it up and sending it out properly. ;-\

Any progress? Anything I can help with?

I was hoping that 5.17 would fix this but I just merged Linus's tree
with netdev today and the warnings are still there :(

2022-01-21 19:57:21

by Borislav Petkov

[permalink] [raw]
Subject: Re: vmlinux.o: warning: objtool: do_machine_check()+0x5fa: call to memset() leaves .noinstr.text section

On Wed, Jan 19, 2022 at 10:22:50AM -0800, Jakub Kicinski wrote:
> I was hoping that 5.17 would fix this but I just merged Linus's tree
> with netdev today and the warnings are still there :(

Hmm, weird. The set which is supposed to address this got merged last
week:

7e740ae63504 ("Merge tag 'ras_core_for_v5.17_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip")

How exactly can I reproduce what you're seeing?

I need to merge which commit into which branch and then use which
.config to reproduce?

Thx.

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Ivo Totev, HRB 36809, AG Nürnberg