2023-04-03 02:54:48

by Chunfeng Yun

Subject: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks

Add optional clock 'xhci_ck' and 'frmcnt_ck';
Add optional property "assigned-clock" and "assigned-clock-parents";

Signed-off-by: Chunfeng Yun <[email protected]>
---
.../devicetree/bindings/usb/mediatek,mtu3.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
index d2655173e108..50c15f2ce14d 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
@@ -66,6 +66,8 @@ properties:
- description: Reference clock used by low power mode etc
- description: Mcu bus clock for register access
- description: DMA bus clock for data transfer
+ - description: DRD controller clock
+ - description: Frame count clock

clock-names:
minItems: 1
@@ -74,6 +76,16 @@ properties:
- const: ref_ck
- const: mcu_ck
- const: dma_ck
+ - const: xhci_ck
+ - const: frmcnt_ck
+
+ assigned-clocks:
+ minItems: 1
+ maxItems: 6
+
+ assigned-clock-parents:
+ minItems: 1
+ maxItems: 6

phys:
description:
--
2.18.0

2023-04-04 13:49:32

by Rob Herring

Subject: Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks

On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> Add optional clock 'xhci_ck' and 'frmcnt_ck';
> Add optional property "assigned-clock" and "assigned-clock-parents";
>
> Signed-off-by: Chunfeng Yun <[email protected]>
> ---
> .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index d2655173e108..50c15f2ce14d 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -66,6 +66,8 @@ properties:
> - description: Reference clock used by low power mode etc
> - description: Mcu bus clock for register access
> - description: DMA bus clock for data transfer
> + - description: DRD controller clock
> + - description: Frame count clock
>
> clock-names:
> minItems: 1
> @@ -74,6 +76,16 @@ properties:
> - const: ref_ck
> - const: mcu_ck
> - const: dma_ck
> + - const: xhci_ck
> + - const: frmcnt_ck
> +
> + assigned-clocks:
> + minItems: 1
> + maxItems: 6
> +
> + assigned-clock-parents:
> + minItems: 1
> + maxItems: 6

You don't need to include assigned-clocks properties. They are
implicitly allowed (when clocks is present).

Rob

2023-04-07 08:06:49

by Chunfeng Yun

Subject: Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks

On Tue, 2023-04-04 at 08:43 -0500, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> > Add optional clock 'xhci_ck' and 'frmcnt_ck';
> > Add optional property "assigned-clock" and "assigned-clock-
> > parents";
> >
> > Signed-off-by: Chunfeng Yun <[email protected]>
> > ---
> > .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12
> > ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > index d2655173e108..50c15f2ce14d 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > @@ -66,6 +66,8 @@ properties:
> > - description: Reference clock used by low power mode etc
> > - description: Mcu bus clock for register access
> > - description: DMA bus clock for data transfer
> > + - description: DRD controller clock
> > + - description: Frame count clock
> >
> > clock-names:
> > minItems: 1
> > @@ -74,6 +76,16 @@ properties:
> > - const: ref_ck
> > - const: mcu_ck
> > - const: dma_ck
> > + - const: xhci_ck
> > + - const: frmcnt_ck
> > +
> > + assigned-clocks:
> > + minItems: 1
> > + maxItems: 6
> > +
> > + assigned-clock-parents:
> > + minItems: 1
> > + maxItems: 6
>
> You don't need to include assigned-clocks properties. They are
> implicitly allowed (when clocks is present).
Got it, will modify it, thanks a lot

>
> Rob