2017-11-02 15:12:46

by Alexei Starovoitov

[permalink] [raw]
Subject: Re: [PATCH v2 net-next 3/5] bpf, cgroup: implement eBPF-based device controller for cgroup v2

On 11/2/17 7:54 AM, Roman Gushchin wrote:
> +#define DEV_BPF_ACC_MKNOD (1ULL << 0)
> +#define DEV_BPF_ACC_READ (1ULL << 1)
> +#define DEV_BPF_ACC_WRITE (1ULL << 2)
> +
> +#define DEV_BPF_DEV_BLOCK (1ULL << 0)
> +#define DEV_BPF_DEV_CHAR (1ULL << 1)
> +

all macros in bpf.h start with BPF_
To be consistent with the rest can you rename above to BPF_DEVCG_.. ?

From 1582966666299140143@xxx Thu Nov 02 14:57:33 +0000 2017
X-GM-THRID: 1582966666299140143
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread