2024-04-28 15:36:32

by Christophe JAILLET

Subject: [PATCH] leds: aat1290: Remove an unused field in struct aat1290_led

In "struct aat1290_led", the 'torch_brightness' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

It was added added in commit 49c34b8e0f43 ("leds: Add driver for AAT1290
flash LED controller") and its only user was removed in commit 269e92da8b07
("leds: aat1290: Remove work queue").
---
drivers/leds/flash/leds-aat1290.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/leds/flash/leds-aat1290.c b/drivers/leds/flash/leds-aat1290.c
index 0195935a7c99..e8f9dd293592 100644
--- a/drivers/leds/flash/leds-aat1290.c
+++ b/drivers/leds/flash/leds-aat1290.c
@@ -77,8 +77,6 @@ struct aat1290_led {
int *mm_current_scale;
/* device mode */
bool movie_mode;
- /* brightness cache */
- unsigned int torch_brightness;
};

static struct aat1290_led *fled_cdev_to_led(
--
2.44.0

2024-05-02 17:09:55

by Lee Jones

Subject: Re: (subset) [PATCH] leds: aat1290: Remove an unused field in struct aat1290_led

On Sun, 28 Apr 2024 17:34:55 +0200, Christophe JAILLET wrote:
> In "struct aat1290_led", the 'torch_brightness' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
>

Applied, thanks!

[1/1] leds: aat1290: Remove an unused field in struct aat1290_led
commit: 678ba7d25467c06850d0d2922108573ea7346a48

--
Lee Jones [李琼斯]