2022-09-30 08:09:58

by Krzysztof Kozlowski

Subject: Re: [PATCH v6 10/17] arm64: dts: Add AMD Pensando Elba SoC support

On 20/08/2022 21:57, Brad Larson wrote:
> From: Brad Larson <[email protected]>
>
> Add AMD Pensando common and Elba SoC specific device nodes
>
> Signed-off-by: Brad Larson <[email protected]>

(...)

> +
> +&ahb_clk {
> + clock-frequency = <400000000>;
> +};
> +
> +&emmc_clk {
> + clock-frequency = <200000000>;
> +};
> +
> +&flash_clk {
> + clock-frequency = <400000000>;
> +};
> +
> +&ref_clk {
> + clock-frequency = <156250000>;
> +};
> +
> +&qspi {
> + status = "okay";

Blank line between properties and device nodes.

> + flash0: flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + spi-rx-bus-width = <2>;
> + m25p,fast-read;
> + cdns,read-delay = <0>;
> + cdns,tshsl-ns = <0>;
> + cdns,tsd2d-ns = <0>;
> + cdns,tchsh-ns = <0>;
> + cdns,tslch-ns = <0>;
> + };
> +};
> +
> +&gpio0 {
> + status = "okay";
> +};
> +
> +&emmc {
> + bus-width = <8>;
> + cap-mmc-hw-reset;
> + reset-names = "hw";
> + resets = <&rstc 0>;
> + status = "okay";
> +};
> +
> +&wdt0 {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + clock-frequency = <100000>;
> + status = "okay";

Blank line between properties and device nodes.

> + rtc@51 {
> + compatible = "nxp,pcf85263";
> + reg = <0x51>;
> + };
> +};
> +
> +&spi0 {
> + num-cs = <4>;
> + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>,
> + <&porta 7 GPIO_ACTIVE_LOW>;
> + status = "okay";

Blank line between properties and device nodes.

> + sysc: system-controller@0 {
> + compatible = "amd,pensando-elbasr";

Best regards,
Krzysztof

2022-10-04 20:23:40

by Larson, Bradley

Subject: Re: [PATCH v6 10/17] arm64: dts: Add AMD Pensando Elba SoC support

On 9/30/22 12:27 AM, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 20/08/2022 21:57, Brad Larson wrote:
>> From: Brad Larson <[email protected]>
>>
>> Add AMD Pensando common and Elba SoC specific device nodes
>>
>> Signed-off-by: Brad Larson <[email protected]>
> (...)
>
>> +
>> +&ahb_clk {
>> + clock-frequency = <400000000>;
>> +};
>> +
>> +&emmc_clk {
>> + clock-frequency = <200000000>;
>> +};
>> +
>> +&flash_clk {
>> + clock-frequency = <400000000>;
>> +};
>> +
>> +&ref_clk {
>> + clock-frequency = <156250000>;
>> +};
>> +
>> +&qspi {
>> + status = "okay";
> Blank line between properties and device nodes.

Added blank line.


>> +
>> +&wdt0 {
>> + status = "okay";
>> +};
>> +
>> +&i2c0 {
>> + clock-frequency = <100000>;
>> + status = "okay";
> Blank line between properties and device nodes.

Added blank line.


>> + rtc@51 {
>> + compatible = "nxp,pcf85263";
>> + reg = <0x51>;
>> + };
>> +};
>> +
>> +&spi0 {
>> + num-cs = <4>;
>> + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>,
>> + <&porta 7 GPIO_ACTIVE_LOW>;
>> + status = "okay";
> Blank line between properties and device nodes.


Added blank line.


>> + sysc: system-controller@0 {
>> + compatible = "amd,pensando-elbasr";


Regards,
Brad