2024-02-12 17:51:00

by Christophe Kerello

[permalink] [raw]
Subject: [PATCH 04/12] memory: stm32-fmc2-ebi: add MP25 support

Add MP25 SOC support. RNB and NWAIT signals are differentiated.

Signed-off-by: Christophe Kerello <[email protected]>
---
drivers/memory/stm32-fmc2-ebi.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/memory/stm32-fmc2-ebi.c b/drivers/memory/stm32-fmc2-ebi.c
index 5f82686689ee..d79dcb6c239a 100644
--- a/drivers/memory/stm32-fmc2-ebi.c
+++ b/drivers/memory/stm32-fmc2-ebi.c
@@ -1203,11 +1203,19 @@ static const struct stm32_fmc2_ebi_data stm32_fmc2_ebi_mp1_data = {
.rnb_for_nand = false,
};

+static const struct stm32_fmc2_ebi_data stm32_fmc2_ebi_mp25_data = {
+ .rnb_for_nand = true,
+};
+
static const struct of_device_id stm32_fmc2_ebi_match[] = {
{
.compatible = "st,stm32mp1-fmc2-ebi",
.data = &stm32_fmc2_ebi_mp1_data,
},
+ {
+ .compatible = "st,stm32mp25-fmc2-ebi",
+ .data = &stm32_fmc2_ebi_mp25_data,
+ },
{}
};
MODULE_DEVICE_TABLE(of, stm32_fmc2_ebi_match);
--
2.25.1



2024-02-13 07:36:49

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 04/12] memory: stm32-fmc2-ebi: add MP25 support

On 12/02/2024 18:48, Christophe Kerello wrote:
> Add MP25 SOC support. RNB and NWAIT signals are differentiated.

s/SOC/SoC/
everywhere

>

The way you split patches is a bit odd. Shall we understand that this
patch is the complete MP25 SoC support?

Best regards,
Krzysztof


2024-02-13 12:31:32

by Christophe Kerello

[permalink] [raw]
Subject: Re: [PATCH 04/12] memory: stm32-fmc2-ebi: add MP25 support



On 2/13/24 08:36, Krzysztof Kozlowski wrote:
> On 12/02/2024 18:48, Christophe Kerello wrote:
>> Add MP25 SOC support. RNB and NWAIT signals are differentiated.
>

Hi Krzysztof,

> s/SOC/SoC/
> everywhere

Ok.

>
>>
>
> The way you split patches is a bit odd. Shall we understand that this
> patch is the complete MP25 SoC support?
>

No, it is not the full support but the way the FMC2 IP has been
integrated in this SoC. As patch 5 has to be written, I am going to
merge this patch and patch 5 in one patch. I am going to follow your
recommendation and use the platform data to distinguish between each
variant.

Regards,
Christophe Kerello.

> Best regards,
> Krzysztof
>