2023-10-16 05:37:02

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/4] remoteproc: qcom_wcnss: Add WCN3680B compatible

On 15/10/2023 22:03, Luca Weiss wrote:
> Add a compatible for the WCN3680B chip used with some Qualcomm SoCs.
>
> It shares the same regulator setup as WCN3680, so we can reuse the
> driver data for that.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> drivers/remoteproc/qcom_wcnss_iris.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c
> index dd36fd077911..22acc609105f 100644
> --- a/drivers/remoteproc/qcom_wcnss_iris.c
> +++ b/drivers/remoteproc/qcom_wcnss_iris.c
> @@ -99,6 +99,7 @@ static const struct of_device_id iris_of_match[] = {
> { .compatible = "qcom,wcn3660", .data = &wcn3660_data },
> { .compatible = "qcom,wcn3660b", .data = &wcn3680_data },
> { .compatible = "qcom,wcn3680", .data = &wcn3680_data },
> + { .compatible = "qcom,wcn3680b", .data = &wcn3680_data },

Just make devices compatible and no need for this driver change.

Best regards,
Krzysztof


2023-10-17 16:28:37

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/4] remoteproc: qcom_wcnss: Add WCN3680B compatible



On 10/16/23 07:35, Krzysztof Kozlowski wrote:
> On 15/10/2023 22:03, Luca Weiss wrote:
>> Add a compatible for the WCN3680B chip used with some Qualcomm SoCs.
>>
>> It shares the same regulator setup as WCN3680, so we can reuse the
>> driver data for that.
>>
>> Signed-off-by: Luca Weiss <[email protected]>
>> ---
>> drivers/remoteproc/qcom_wcnss_iris.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c
>> index dd36fd077911..22acc609105f 100644
>> --- a/drivers/remoteproc/qcom_wcnss_iris.c
>> +++ b/drivers/remoteproc/qcom_wcnss_iris.c
>> @@ -99,6 +99,7 @@ static const struct of_device_id iris_of_match[] = {
>> { .compatible = "qcom,wcn3660", .data = &wcn3660_data },
>> { .compatible = "qcom,wcn3660b", .data = &wcn3680_data },
>> { .compatible = "qcom,wcn3680", .data = &wcn3680_data },
>> + { .compatible = "qcom,wcn3680b", .data = &wcn3680_data },
>
> Just make devices compatible and no need for this driver change.
Or reconsider given <[email protected]>

Konrad