2021-09-25 22:23:10

by Colin King

Subject: [PATCH] HID: thrustmaster: Initialized pointer twi with NULL rather than 0

From: Colin Ian King <[email protected]>

Pointers should be initialized with NULL rather than 0. Fix this.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/hid/hid-thrustmaster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index d44550aa8805..aa874f075bf9 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -205,7 +205,7 @@ static void thrustmaster_model_handler(struct urb *urb)
struct tm_wheel *tm_wheel = hid_get_drvdata(hdev);
uint16_t model = 0;
int i, ret;
- const struct tm_wheel_info *twi = 0;
+ const struct tm_wheel_info *twi = NULL;

if (urb->status) {
hid_err(hdev, "URB to get model id failed with error %d\n", urb->status);
--
2.32.0

2021-09-25 22:27:15

by Colin King

Subject: NAK: [PATCH] HID: thrustmaster: Initialized pointer twi with NULL rather than 0

On 25/09/2021 23:22, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Pointers should be initialized with NULL rather than 0. Fix this.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/hid/hid-thrustmaster.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
> index d44550aa8805..aa874f075bf9 100644
> --- a/drivers/hid/hid-thrustmaster.c
> +++ b/drivers/hid/hid-thrustmaster.c
> @@ -205,7 +205,7 @@ static void thrustmaster_model_handler(struct urb *urb)
> struct tm_wheel *tm_wheel = hid_get_drvdata(hdev);
> uint16_t model = 0;
> int i, ret;
> - const struct tm_wheel_info *twi = 0;
> + const struct tm_wheel_info *twi = NULL;
>
> if (urb->status) {
> hid_err(hdev, "URB to get model id failed with error %d\n", urb->status);
>

NACK, I spotted another pointer than needs the same change, will send a V2.