2022-04-05 02:25:01

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] drm/bridge: fix it6505 Kconfig terms

Fix around 50 undefined references when DRM_ITE_IT6505=y while
DRM_DP_AUX_BUS=m and DRM_DP_HELPER=m.

Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Allen Chen <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: Hermes Wu <[email protected]>
Cc: AngeloGioacchino Del Regno <[email protected]>
Cc: Andrzej Hajda <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
---
drivers/gpu/drm/bridge/Kconfig | 2 ++
1 file changed, 2 insertions(+)

--- linux-next-20220401.orig/drivers/gpu/drm/bridge/Kconfig
+++ linux-next-20220401/drivers/gpu/drm/bridge/Kconfig
@@ -78,6 +78,8 @@ config DRM_ITE_IT6505
tristate "ITE IT6505 DisplayPort bridge"
depends on OF
select DRM_KMS_HELPER
+ select DRM_DP_AUX_BUS
+ select DRM_DP_HELPER
select EXTCON
help
ITE IT6505 DisplayPort bridge chip driver.


2022-04-26 23:34:00

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: fix it6505 Kconfig terms

Hi,

On 03/04/2022 17:16, Randy Dunlap wrote:
> Fix around 50 undefined references when DRM_ITE_IT6505=y while
> DRM_DP_AUX_BUS=m and DRM_DP_HELPER=m.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Allen Chen <[email protected]>
> Cc: Robert Foss <[email protected]>
> Cc: Hermes Wu <[email protected]>
> Cc: AngeloGioacchino Del Regno <[email protected]>
> Cc: Andrzej Hajda <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Jonas Karlman <[email protected]>
> Cc: Jernej Skrabec <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: [email protected]
> ---
> drivers/gpu/drm/bridge/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20220401.orig/drivers/gpu/drm/bridge/Kconfig
> +++ linux-next-20220401/drivers/gpu/drm/bridge/Kconfig
> @@ -78,6 +78,8 @@ config DRM_ITE_IT6505
> tristate "ITE IT6505 DisplayPort bridge"
> depends on OF
> select DRM_KMS_HELPER
> + select DRM_DP_AUX_BUS
> + select DRM_DP_HELPER

The indentation is wrong here.

> select EXTCON
> help
> ITE IT6505 DisplayPort bridge chip driver.

Neil