2022-10-08 08:18:34

by Jiapeng Chong

Subject: [PATCH] acerhdf: remove unneeded semicolon

./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/platform/x86/acerhdf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 1956469c3457..6cf7f2a8a074 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
fanoff, fanon, fanon);
fanoff = fanon;
- };
+ }

trips[0].temperature = fanon;
trips[0].hysteresis = fanon - fanoff;
--
2.20.1.7.g153144c

2022-10-24 19:21:38

by Hans de Goede

Subject: Re: [PATCH] acerhdf: remove unneeded semicolon

Hi,

On 10/8/22 09:04, Jiapeng Chong wrote:
> ./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

This patch does not apply:

[hans@x1 platform-drivers-x86]$ git am -s ~/1.eml
Applying: acerhdf: remove unneeded semicolon
error: patch failed: drivers/platform/x86/acerhdf.c:341
error: drivers/platform/x86/acerhdf.c: patch does not apply
Patch failed at 0001 acerhdf: remove unneeded semicolon
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Please make sure that you base this on the latest version of
the acerhdf code from:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

Regards,

Hans



> ---
> drivers/platform/x86/acerhdf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 1956469c3457..6cf7f2a8a074 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
> pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
> fanoff, fanon, fanon);
> fanoff = fanon;
> - };
> + }
>
> trips[0].temperature = fanon;
> trips[0].hysteresis = fanon - fanoff;