2022-09-25 20:46:57

by Luca Weiss

Subject: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio

All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
also validated by the dt binding check. Fix it.

Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm/boot/dts/qcom-pmx65.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-pmx65.dtsi b/arch/arm/boot/dts/qcom-pmx65.dtsi
index abf229a8b75a..1c7fdf59c1f5 100644
--- a/arch/arm/boot/dts/qcom-pmx65.dtsi
+++ b/arch/arm/boot/dts/qcom-pmx65.dtsi
@@ -20,7 +20,7 @@ pmx65_temp: temp-alarm@a00 {
#thermal-sensor-cells = <0>;
};

- pmx65_gpios: pinctrl@8800 {
+ pmx65_gpios: gpio@8800 {
compatible = "qcom,pmx65-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
--
2.37.3

2022-09-26 09:11:16

by Neil Armstrong

Subject: Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio

On 25/09/2022 21:06, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> arch/arm/boot/dts/qcom-pmx65.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pmx65.dtsi b/arch/arm/boot/dts/qcom-pmx65.dtsi
> index abf229a8b75a..1c7fdf59c1f5 100644
> --- a/arch/arm/boot/dts/qcom-pmx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-pmx65.dtsi
> @@ -20,7 +20,7 @@ pmx65_temp: temp-alarm@a00 {
> #thermal-sensor-cells = <0>;
> };
>
> - pmx65_gpios: pinctrl@8800 {
> + pmx65_gpios: gpio@8800 {
> compatible = "qcom,pmx65-gpio", "qcom,spmi-gpio";
> reg = <0x8800>;
> gpio-controller;

Reviewed-by: Neil Armstrong <[email protected]>

2022-09-26 09:44:26

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio

On 25/09/2022 21:06, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
>
> Signed-off-by: Luca Weiss <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-10-18 04:00:00

by Bjorn Andersson

Subject: Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio

On Sun, 25 Sep 2022 21:06:21 +0200, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
>
>

Applied, thanks!

[1/1] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio
commit: da76bc88bde1dc3f547078282e30a88c371699ad

Best regards,
--
Bjorn Andersson <[email protected]>