2020-11-13 00:24:50

by Michał Mirosław

[permalink] [raw]
Subject: [PATCH RESEND 2/4] regulator: debug early supply resolving

Help debugging the case when set_machine_constraints() needs to be
repeated.

Signed-off-by: Michał Mirosław <[email protected]>
---
drivers/regulator/core.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index bcd64ba21fb9..ad36f03d7ee6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -5296,6 +5296,8 @@ regulator_register(const struct regulator_desc *regulator_desc,
/* FIXME: this currently triggers a chicken-and-egg problem
* when creating -SUPPLY symlink in sysfs to a regulator
* that is just being created */
+ rdev_dbg(rdev, "will resolve supply early: %s\n",
+ rdev->supply_name);
ret = regulator_resolve_supply(rdev);
if (!ret)
ret = set_machine_constraints(rdev);
--
2.20.1


2020-11-13 13:18:56

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH RESEND 2/4] regulator: debug early supply resolving

On Fri, Nov 13, 2020 at 01:20:27AM +0100, Michał Mirosław wrote:
> Help debugging the case when set_machine_constraints() needs to be
> repeated.
>
> Signed-off-by: Michał Mirosław <[email protected]>

Please when sending patches containing a mix of different kinds of
patches put any fixes at the start of the series before anything else,
including new features and trace additions like this one. This makes it
much easier to send things as fixes without unneeded dependencies on the
new stuff.


Attachments:
(No filename) (519.00 B)
signature.asc (499.00 B)
Download all attachments