2020-04-20 09:02:37

by Benjamin GAIGNARD

Subject: [RESEND v6 1/6] dt-bindings: mfd: Document STM32 low power timer bindings

Add a subnode to STM low power timer bindings to support timer driver

Signed-off-by: Benjamin Gaignard <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
index ddf190cb800b..64bab1c3bdac 100644
--- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
@@ -33,6 +33,9 @@ properties:
items:
- const: mux

+ interrupts:
+ maxItems: 1
+
"#address-cells":
const: 1

@@ -93,6 +96,16 @@ patternProperties:
required:
- compatible

+ timer:
+ type: object
+
+ properties:
+ compatible:
+ const: st,stm32-lptimer-timer
+
+ required:
+ - compatible
+
required:
- "#address-cells"
- "#size-cells"
@@ -106,11 +119,13 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/clock/stm32mp1-clks.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
timer@40002400 {
compatible = "st,stm32-lptimer";
reg = <0x40002400 0x400>;
clocks = <&timer_clk>;
clock-names = "mux";
+ interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;

@@ -131,6 +146,10 @@ examples:
timer {
compatible = "st,stm32-lptimer-timer";
};
+
+ timer {
+ compatible = "st,stm32-lptimer-timer";
+ };
};

...
--
2.15.0

2020-04-20 09:37:07

by Fabrice Gasnier

Subject: Re: [RESEND v6 1/6] dt-bindings: mfd: Document STM32 low power timer bindings

On 4/20/20 10:59 AM, Benjamin Gaignard wrote:
> Add a subnode to STM low power timer bindings to support timer driver
>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
> index ddf190cb800b..64bab1c3bdac 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
> @@ -33,6 +33,9 @@ properties:
> items:
> - const: mux
>
> + interrupts:
> + maxItems: 1
> +
> "#address-cells":
> const: 1
>
> @@ -93,6 +96,16 @@ patternProperties:
> required:
> - compatible
>
> + timer:
> + type: object
> +
> + properties:
> + compatible:
> + const: st,stm32-lptimer-timer
> +
> + required:
> + - compatible
> +
> required:
> - "#address-cells"
> - "#size-cells"
> @@ -106,11 +119,13 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/stm32mp1-clks.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> timer@40002400 {
> compatible = "st,stm32-lptimer";
> reg = <0x40002400 0x400>;
> clocks = <&timer_clk>;
> clock-names = "mux";
> + interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -131,6 +146,10 @@ examples:
> timer {
> compatible = "st,stm32-lptimer-timer";
> };
> +
> + timer {
> + compatible = "st,stm32-lptimer-timer";
> + };

Hi Benjamin,

It looks like the compatible is duplicated in this example.
Also, from "PATCH v6" I don't see the wakeup-source flag in your resend.
Can you double-check ?

Thanks,
Best Regards,
Fabrice

> };
>
> ...
>

2020-04-20 12:17:33

by Benjamin GAIGNARD

Subject: Re: [RESEND v6 1/6] dt-bindings: mfd: Document STM32 low power timer bindings

On 4/20/20 11:34 AM, Fabrice Gasnier wrote:
> On 4/20/20 10:59 AM, Benjamin Gaignard wrote:
>> Add a subnode to STM low power timer bindings to support timer driver
>>
>> Signed-off-by: Benjamin Gaignard <[email protected]>
>> Reviewed-by: Rob Herring <[email protected]>
>> ---
>> .../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
>> index ddf190cb800b..64bab1c3bdac 100644
>> --- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
>> @@ -33,6 +33,9 @@ properties:
>> items:
>> - const: mux
>>
>> + interrupts:
>> + maxItems: 1
>> +
>> "#address-cells":
>> const: 1
>>
>> @@ -93,6 +96,16 @@ patternProperties:
>> required:
>> - compatible
>>
>> + timer:
>> + type: object
>> +
>> + properties:
>> + compatible:
>> + const: st,stm32-lptimer-timer
>> +
>> + required:
>> + - compatible
>> +
>> required:
>> - "#address-cells"
>> - "#size-cells"
>> @@ -106,11 +119,13 @@ additionalProperties: false
>> examples:
>> - |
>> #include <dt-bindings/clock/stm32mp1-clks.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> timer@40002400 {
>> compatible = "st,stm32-lptimer";
>> reg = <0x40002400 0x400>;
>> clocks = <&timer_clk>;
>> clock-names = "mux";
>> + interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>;
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> @@ -131,6 +146,10 @@ examples:
>> timer {
>> compatible = "st,stm32-lptimer-timer";
>> };
>> +
>> + timer {
>> + compatible = "st,stm32-lptimer-timer";
>> + };
> Hi Benjamin,
>
> It looks like the compatible is duplicated in this example.
> Also, from "PATCH v6" I don't see the wakeup-source flag in your resend.
> Can you double-check ?
I have rebased the serie on top of v5.7-rc2, I haven't see that the
bindings got merged
and, unlucky, these hunks can still be applied and becomes duplicated.
I will send a v7.

Benjamin
>
> Thanks,
> Best Regards,
> Fabrice
>
>> };
>>
>> ...
>>