2021-03-20 19:10:21

by Bhaskar Chowdhury

[permalink] [raw]
Subject: [PATCH] KVM: x86: A typo fix


s/resued/resumed/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
arch/x86/include/asm/kvm_host.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 9bc091ecaaeb..eae82551acb1 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
/*
* EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
* userspace I/O) to indicate that the emulation context
- * should be resued as is, i.e. skip initialization of
+ * should be resumed as is, i.e. skip initialization of
* emulation context, instruction fetch and decode.
*
* EMULTYPE_TRAP_UD - Set when emulating an intercepted #UD from hardware.
--
2.26.2


2021-03-20 19:15:31

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] KVM: x86: A typo fix



On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:

>
> s/resued/resumed/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Acked-by: Randy Dunlap <[email protected]>


> ---
> arch/x86/include/asm/kvm_host.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 9bc091ecaaeb..eae82551acb1 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
> /*
> * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
> * userspace I/O) to indicate that the emulation context
> - * should be resued as is, i.e. skip initialization of
> + * should be resumed as is, i.e. skip initialization of
> * emulation context, instruction fetch and decode.
> *
> * EMULTYPE_TRAP_UD - Set when emulating an intercepted #UD from hardware.
> --
> 2.26.2
>
>

2021-03-21 23:59:09

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] KVM: x86: A typo fix


* Randy Dunlap <[email protected]> wrote:

>
>
> On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:
>
> >
> > s/resued/resumed/
> >
> > Signed-off-by: Bhaskar Chowdhury <[email protected]>
>
> Acked-by: Randy Dunlap <[email protected]>
>
>
> > ---
> > arch/x86/include/asm/kvm_host.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> > index 9bc091ecaaeb..eae82551acb1 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
> > /*
> > * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
> > * userspace I/O) to indicate that the emulation context
> > - * should be resued as is, i.e. skip initialization of
> > + * should be resumed as is, i.e. skip initialization of
> > * emulation context, instruction fetch and decode.

This is the *wrong* fix, the correct word in this context is 'reused',
not 'resumed' ...

See how I fixed most arch/x86/ typo fixes in tip:x86/cleanups:

d9f6e12fb0b7: ("x86: Fix various typos in comments")
163b099146b8: ("x86: Fix various typos in comments, take #2")

These single file typo fixes are a bad idea for another reason as
well, as they create a lot of unnecessary churn.

Thanks,

Ingo

2021-03-22 05:32:04

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] KVM: x86: A typo fix

On 23:54 Sun 21 Mar 2021, Ingo Molnar wrote:
>
>
>These single file typo fixes are a bad idea for another reason as
>well, as they create a lot of unnecessary churn.
>
Huh! I was expecting it from the moment I started doing it ...finally it arrives.

I am not sure about "so called workflowo of others" ..I am gonna do it in my
way as long as it providing good.

I think this is best way to do it.

~Bhaskar


Attachments:
(No filename) (424.00 B)
signature.asc (499.00 B)
Download all attachments