2019-05-23 13:21:11

by Thomas Gleixner

Subject: Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

On Thu, 23 May 2019, TonyWWang-oc wrote:
> --- /dev/null
> +++ b/arch/x86/kernel/cpu/zhaoxin.c
> @@ -0,0 +1,178 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Zhaoxin Processor Support for Linux
> + *
> + * Copyright (c) 2019 Shanghai Zhaoxin Semiconductor Co., Ltd.
> + *
> + * Author: David Wang <[email protected]>
> + *
> + * This file is licensed under the terms of the GNU General
> + * License v2.0 or later. See file COPYING for details.

Please remove this boilerplate text. The SPDX license identifier is
sufficient, but looking at that:

> +// SPDX-License-Identifier: GPL-2.0

That clearly disagrees with your boilerplate text which says 'v2.0 or
later'. Assumed that you want or later, then the SPDX id needs to say so.

// SPDX-License-Identifier: GPL-2.0-or-later

Thanks,

tglx

2019-05-24 08:35:04

by Tony W Wang-oc

Subject: 答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

On Thu, May 23, 2019, Thomas Gleixner wrote:
>> + * This file is licensed under the terms of the GNU General
>> + * License v2.0 or later. See file COPYING for details.
>
>Please remove this boilerplate text. The SPDX license identifier is
>sufficient, but looking at that:
>
>> +// SPDX-License-Identifier: GPL-2.0
>
>That clearly disagrees with your boilerplate text which says 'v2.0 or
>later'. Assumed that you want or later, then the SPDX id needs to say so.
>
>// SPDX-License-Identifier: GPL-2.0-or-later

Ok, I will adjust this text after sort this out with our lawyers.

Thanks
TonyWWang-oc