2019-04-04 10:06:04

by Colin King

Subject: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

From: Colin Ian King <[email protected]>

The check on record->event is always true because the wrong operator
is being used, used && instead of ||

Addresses-Coverity: ("Constant expression result")
Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
index 76cd09410d9a..be5befd92d16 100644
--- a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
+++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
@@ -869,7 +869,7 @@ static void opa_vnic_event(struct ib_event_handler *handler,
record->event, dev_name(&record->device->dev),
record->element.port_num);

- if (record->event != IB_EVENT_PORT_ERR ||
+ if (record->event != IB_EVENT_PORT_ERR &&
record->event != IB_EVENT_PORT_ACTIVE)
return;

--
2.20.1

2019-04-04 11:26:08

by Dennis Dalessandro

Subject: Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

On 4/4/2019 6:04 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The check on record->event is always true because the wrong operator
> is being used, used && instead of ||
>
> Addresses-Coverity: ("Constant expression result")
> Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> index 76cd09410d9a..be5befd92d16 100644
> --- a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> @@ -869,7 +869,7 @@ static void opa_vnic_event(struct ib_event_handler *handler,
> record->event, dev_name(&record->device->dev),
> record->element.port_num);
>
> - if (record->event != IB_EVENT_PORT_ERR ||
> + if (record->event != IB_EVENT_PORT_ERR &&
> record->event != IB_EVENT_PORT_ACTIVE)
> return;
>
>

Missed this in code review. Thanks!

Acked-by: Dennis Dalessandro <[email protected]>

2019-04-04 11:33:11

by Jason Gunthorpe

Subject: Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

On Thu, Apr 04, 2019 at 07:23:45AM -0400, Dennis Dalessandro wrote:
> On 4/4/2019 6:04 AM, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > The check on record->event is always true because the wrong operator
> > is being used, used && instead of ||
> >
> > Addresses-Coverity: ("Constant expression result")
> > Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray")
> > Signed-off-by: Colin Ian King <[email protected]>
> > drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> > index 76cd09410d9a..be5befd92d16 100644
> > +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> > @@ -869,7 +869,7 @@ static void opa_vnic_event(struct ib_event_handler *handler,
> > record->event, dev_name(&record->device->dev),
> > record->element.port_num);
> > - if (record->event != IB_EVENT_PORT_ERR ||
> > + if (record->event != IB_EVENT_PORT_ERR &&
> > record->event != IB_EVENT_PORT_ACTIVE)
> > return;
> >
>
> Missed this in code review. Thanks!
>
> Acked-by: Dennis Dalessandro <[email protected]>

Applied to for-next, thanks

Jason

2019-04-04 11:37:12

by Mukesh Ojha

Subject: Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

On 4/4/2019 3:34 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The check on record->event is always true because the wrong operator
> is being used, used && instead of ||
>
> Addresses-Coverity: ("Constant expression result")
> Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray")
> Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh
> ---
> drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> index 76cd09410d9a..be5befd92d16 100644
> --- a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> @@ -869,7 +869,7 @@ static void opa_vnic_event(struct ib_event_handler *handler,
> record->event, dev_name(&record->device->dev),
> record->element.port_num);
>
> - if (record->event != IB_EVENT_PORT_ERR ||
> + if (record->event != IB_EVENT_PORT_ERR &&
> record->event != IB_EVENT_PORT_ACTIVE)
> return;
>