ext4 uses generic_file_read_iter(), which already supports this.
Cc: Theodore Ts'o <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
---
Resending this one, as I've been carrying it privately since May. The
necessary bits are now upstream (and XFS/btrfs equiv changes as well),
please consider this one for 5.9. Thanks!
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 2a01e31a032c..1e827410e9e1 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -839,7 +839,7 @@ static int ext4_file_open(struct inode * inode, struct file * filp)
return ret;
}
- filp->f_mode |= FMODE_NOWAIT;
+ filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC;
return dquot_file_open(inode, filp);
}
--
Jens Axboe
On 8/18/20 11:11 AM, Theodore Y. Ts'o wrote:
> On Mon, Aug 03, 2020 at 05:02:11PM -0600, Jens Axboe wrote:
>> ext4 uses generic_file_read_iter(), which already supports this.
>>
>> Cc: Theodore Ts'o <[email protected]>
>> Signed-off-by: Jens Axboe <[email protected]>
>>
>> ---
>>
>> Resending this one, as I've been carrying it privately since May. The
>> necessary bits are now upstream (and XFS/btrfs equiv changes as well),
>> please consider this one for 5.9. Thanks!
>
> The necessary commit only hit upstream as of 5.9-rc1, unless I'm
> missing something? It's on my queue to send to Linus once I get my
> (late) ext4 primary pull request for 5.9.
Right, it went in at the start of the merge window for 5.9. Thanks Ted!
--
Jens Axboe
On Fri, Aug 21, 2020 at 03:26:35PM -0600, Jens Axboe wrote:
> >>> Resending this one, as I've been carrying it privately since May. The
> >>> necessary bits are now upstream (and XFS/btrfs equiv changes as well),
> >>> please consider this one for 5.9. Thanks!
> >>
> >> The necessary commit only hit upstream as of 5.9-rc1, unless I'm
> >> missing something? It's on my queue to send to Linus once I get my
> >> (late) ext4 primary pull request for 5.9.
> >
> > Right, it went in at the start of the merge window for 5.9. Thanks Ted!
>
> Didn't see it in the queue that just sent in, is it still queued up?
It wasn't in the queue which I queued up because that was based on
5.8-rc4. Linus was a bit grumpy (fairly so) because it was late, and
that's totally on me.
He has said that he's going to start ignoring pull requests that
aren't fixes only if this becomes a pattern, so while I can send him
another pull request which will just have that one change, there are
no guarantees he's going to take it at this late date.
Sorry, when you sent me the commit saying that the changes that were
needed were already upstream on August 3rd, I thought that meant that
they were aready in Linus's tree. I should have checked and noticed
that that in fact "ext4: flag as supporting buffered async reads"
wasn't compiling against Linus's upstream tree, so I didn't realize
this needed to be handled as a special case during the merge window.
Cheers,
- Ted
On 10/2/20 2:08 PM, Theodore Y. Ts'o wrote:
> On Mon, Aug 03, 2020 at 05:02:11PM -0600, Jens Axboe wrote:
>> ext4 uses generic_file_read_iter(), which already supports this.
>>
>> Cc: Theodore Ts'o <[email protected]>
>> Signed-off-by: Jens Axboe <[email protected]>
>
> Applied, thanks. (And apologies for the delay.)
Well, the topic took a bit of a detour! Thanks Ted.
--
Jens Axboe