2022-08-29 13:20:41

by Maxime Ripard

Subject: [PATCH v2 24/41] drm/vc4: vec: Remove empty mode_fixup

The mode_fixup hooks are deprecated, and the behaviour we implement is the

default one anyway. Let's remove it.



Signed-off-by: Maxime Ripard <[email protected]>



diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c

index d5140fe0be4f..d521ffd8d75c 100644

--- a/drivers/gpu/drm/vc4/vc4_vec.c

+++ b/drivers/gpu/drm/vc4/vc4_vec.c

@@ -483,14 +483,6 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder)

drm_dev_exit(idx);

}



-

-static bool vc4_vec_encoder_mode_fixup(struct drm_encoder *encoder,

- const struct drm_display_mode *mode,

- struct drm_display_mode *adjusted_mode)

-{

- return true;

-}

-

static void vc4_vec_encoder_atomic_mode_set(struct drm_encoder *encoder,

struct drm_crtc_state *crtc_state,

struct drm_connector_state *conn_state)

@@ -518,7 +510,6 @@ static int vc4_vec_encoder_atomic_check(struct drm_encoder *encoder,

static const struct drm_encoder_helper_funcs vc4_vec_encoder_helper_funcs = {

.disable = vc4_vec_encoder_disable,

.enable = vc4_vec_encoder_enable,

- .mode_fixup = vc4_vec_encoder_mode_fixup,

.atomic_check = vc4_vec_encoder_atomic_check,

.atomic_mode_set = vc4_vec_encoder_atomic_mode_set,

};



--

b4 0.10.0-dev-65ba7

2022-08-30 15:38:21

by Noralf Trønnes

Subject: Re: [PATCH v2 24/41] drm/vc4: vec: Remove empty mode_fixup

Den 29.08.2022 15.11, skrev Maxime Ripard:
> The mode_fixup hooks are deprecated, and the behaviour we implement is the
>
> default one anyway. Let's remove it.
>
>
>
> Signed-off-by: Maxime Ripard <[email protected]>
>

Reviewed-by: Noralf Trønnes <[email protected]>

2022-09-07 08:50:29

by Maxime Ripard

Subject: Re: (subset) [PATCH v2 24/41] drm/vc4: vec: Remove empty mode_fixup

On Mon, 29 Aug 2022 15:11:38 +0200, Maxime Ripard wrote:
> The mode_fixup hooks are deprecated, and the behaviour we implement is the
> default one anyway. Let's remove it.
>
>

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime