2024-03-13 07:13:17

by Wasim Nazir

[permalink] [raw]
Subject: [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board

Document board bindings for Rb5gen2.
Rb5gen2 is using Rb5 gen2 SOM which is based on QCS8550 SoC.
RB5gen2 is development kit used for IOT solutions.

Signed-off-by: Wasim Nazir <[email protected]>

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 8115088a6076..de6139db8ef6 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1013,6 +1013,13 @@ properties:
- const: qcom,qcs8550
- const: qcom,sm8550

+ - items:
+ - enum:
+ - qcom,qcs8550-rb5gen2
+ - const: qcom,qcs8550-rb5gen2-som
+ - const: qcom,qcs8550
+ - const: qcom,sm8550
+
- items:
- enum:
- qcom,sm8650-mtp
--
2.43.2



2024-03-13 07:20:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board

On 13/03/2024 08:12, Wasim Nazir wrote:
> Document board bindings for Rb5gen2.
> Rb5gen2 is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2 is development kit used for IOT solutions.
>
> Signed-off-by: Wasim Nazir <[email protected]>
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-03-14 04:15:29

by Caleb Connolly

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board



On 13/03/2024 07:12, Wasim Nazir wrote:
> Document board bindings for Rb5gen2.
> Rb5gen2 is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2 is development kit used for IOT solutions.
>
> Signed-off-by: Wasim Nazir <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 8115088a6076..de6139db8ef6 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1013,6 +1013,13 @@ properties:
> - const: qcom,qcs8550
> - const: qcom,sm8550
>
> + - items:
> + - enum:
> + - qcom,qcs8550-rb5gen2
> + - const: qcom,qcs8550-rb5gen2-som
Is this a Thundercomm SoM like the other RBx boards? If so, shouldn't it
be "thundercomm,c8550-som" (Or "qcom,c8550-som")?
> + - const: qcom,qcs8550
> + - const: qcom,sm8550
> +
> - items:
> - enum:
> - qcom,sm8650-mtp
> --
> 2.43.2
>
>

--
// Caleb (they/them)

2024-03-14 07:01:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board

On 14/03/2024 05:15, Caleb Connolly wrote:
>
>
> On 13/03/2024 07:12, Wasim Nazir wrote:
>> Document board bindings for Rb5gen2.
>> Rb5gen2 is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2 is development kit used for IOT solutions.
>>
>> Signed-off-by: Wasim Nazir <[email protected]>
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 8115088a6076..de6139db8ef6 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1013,6 +1013,13 @@ properties:
>> - const: qcom,qcs8550
>> - const: qcom,sm8550
>>
>> + - items:
>> + - enum:
>> + - qcom,qcs8550-rb5gen2
>> + - const: qcom,qcs8550-rb5gen2-som
> Is this a Thundercomm SoM like the other RBx boards? If so, shouldn't it
> be "thundercomm,c8550-som" (Or "qcom,c8550-som")?

If this is the same product, then yes. It's clearly not Qualcomm:
https://www.thundercomm.com/product/c8550-som/

If not, can you point us to any resources on this?

Eh, let me un-review it.

Best regards,
Krzysztof


2024-03-14 07:02:03

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board

On 13/03/2024 08:19, Krzysztof Kozlowski wrote:
> On 13/03/2024 08:12, Wasim Nazir wrote:
>> Document board bindings for Rb5gen2.
>> Rb5gen2 is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2 is development kit used for IOT solutions.
>>
>> Signed-off-by: Wasim Nazir <[email protected]>
>>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Due to ongoing discussion: un-reviewed.

Best regards,
Krzysztof