2020-04-26 21:52:49

by Guoqing Jiang

Subject: [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private

Since the new pair function is introduced, we can call them to clean the
code in f2fs.h.

Cc: Jaegeuk Kim <[email protected]>
Cc: Chao Yu <[email protected]>
Cc: [email protected]
Signed-off-by: Guoqing Jiang <[email protected]>
---
fs/f2fs/f2fs.h | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index ba470d5687fe..70ad8c51e0fc 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3051,19 +3051,12 @@ static inline void f2fs_set_page_private(struct page *page,
if (PagePrivate(page))
return;

- get_page(page);
- SetPagePrivate(page);
- set_page_private(page, data);
+ set_fs_page_private(page, (void *)data);
}

static inline void f2fs_clear_page_private(struct page *page)
{
- if (!PagePrivate(page))
- return;
-
- set_page_private(page, 0);
- ClearPagePrivate(page);
- f2fs_put_page(page, 0);
+ clear_fs_page_private(page);
}

/*
--
2.17.1

2020-04-27 02:24:30

by Chao Yu

Subject: Re: [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private

On 2020/4/27 5:49, Guoqing Jiang wrote:
> Since the new pair function is introduced, we can call them to clean the
> code in f2fs.h.
>
> Cc: Jaegeuk Kim <[email protected]>
> Cc: Chao Yu <[email protected]>
> Cc: [email protected]
> Signed-off-by: Guoqing Jiang <[email protected]>

Acked-by: Chao Yu <[email protected]>

Thanks,

2020-04-27 08:13:30

by Guoqing Jiang

Subject: Re: [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private

On 4/27/20 4:22 AM, Chao Yu wrote:
> On 2020/4/27 5:49, Guoqing Jiang wrote:
>> Since the new pair function is introduced, we can call them to clean the
>> code in f2fs.h.
>>
>> Cc: Jaegeuk Kim <[email protected]>
>> Cc: Chao Yu <[email protected]>
>> Cc: [email protected]
>> Signed-off-by: Guoqing Jiang <[email protected]>
> Acked-by: Chao Yu <[email protected]>
>

Thanks for your review.

Guoqing