2021-04-20 10:42:54

by Colin King

[permalink] [raw]
Subject: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

From: Colin Ian King <[email protected]>

The pointer tmp_hdr is being assigned a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/lpfc/lpfc_sli.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 06ccc0157bd8..9ead564dd0c0 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17936,7 +17936,6 @@ lpfc_fc_frame_add(struct lpfc_vport *vport, struct hbq_dmabuf *dmabuf)
seq_dmabuf->time_stamp = jiffies;
lpfc_update_rcv_time_stamp(vport);
if (list_empty(&seq_dmabuf->dbuf.list)) {
- temp_hdr = dmabuf->hbuf.virt;
list_add_tail(&dmabuf->dbuf.list, &seq_dmabuf->dbuf.list);
return seq_dmabuf;
}
--
2.30.2


2021-04-22 01:23:49

by James Smart

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

On 4/20/2021 3:41 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer tmp_hdr is being assigned a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Thanks

Reviewed-by: James Smart <[email protected]>

-- james

2021-04-27 02:54:22

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr


Colin,

> The pointer tmp_hdr is being assigned a value that is never read, the
> assignment is redundant and can be removed.

Applied to 5.14/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-05-11 03:27:08

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

On Tue, 20 Apr 2021 11:41:23 +0100, Colin King wrote:

> The pointer tmp_hdr is being assigned a value that is never
> read, the assignment is redundant and can be removed.

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: lpfc: remove redundant assignment to pointer temp_hdr
https://git.kernel.org/mkp/scsi/c/52b259908114

--
Martin K. Petersen Oracle Linux Engineering