2018-10-28 07:00:20

by Sabyasachi Gupta

Subject: [PATCH] arch/sh/mm/consistent.c: Use dma_zalloc_coherent

Replaced dma_alloc_coherent + memset with dma_zalloc_coherant

Signed-off-by: Sabyasachi Gupta <[email protected]>
---
arch/sh/mm/consistent.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
index 792f361..fc8d235 100644
--- a/arch/sh/mm/consistent.c
+++ b/arch/sh/mm/consistent.c
@@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
if (!memsize)
return 0;

- buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
+ buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
if (!buf) {
pr_warning("%s: unable to allocate memory\n", name);
return -ENOMEM;
}

- memset(buf, 0, memsize);

r->flags = IORESOURCE_MEM;
r->start = dma_handle;
--
2.7.4

2019-01-20 13:07:12

by Souptick Joarder

Subject: Re: [PATCH] arch/sh/mm/consistent.c: Use dma_zalloc_coherent

On Sun, Oct 28, 2018 at 12:29 PM Sabyasachi Gupta
<[email protected]> wrote:
>
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherant
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>

Acked-by: Souptick Joarder <[email protected]>

> ---
> arch/sh/mm/consistent.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
> index 792f361..fc8d235 100644
> --- a/arch/sh/mm/consistent.c
> +++ b/arch/sh/mm/consistent.c
> @@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
> if (!memsize)
> return 0;
>
> - buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> + buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> if (!buf) {
> pr_warning("%s: unable to allocate memory\n", name);
> return -ENOMEM;
> }
>
> - memset(buf, 0, memsize);
>
> r->flags = IORESOURCE_MEM;
> r->start = dma_handle;
> --
> 2.7.4
>

2019-01-21 11:46:35

by Robin Murphy

Subject: Re: [PATCH] arch/sh/mm/consistent.c: Use dma_zalloc_coherent

On 28/10/2018 06:58, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherant

Please take a look at linux-next where we've already phased out
dma_zalloc_coherent(). The memset() should still be redundant and worth
cleaning up, though.

Thanks,
Robin.

> Signed-off-by: Sabyasachi Gupta <[email protected]>
> ---
> arch/sh/mm/consistent.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
> index 792f361..fc8d235 100644
> --- a/arch/sh/mm/consistent.c
> +++ b/arch/sh/mm/consistent.c
> @@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
> if (!memsize)
> return 0;
>
> -buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> +buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> if (!buf) {
> pr_warning("%s: unable to allocate memory\n", name);
> return -ENOMEM;
> }
>
> -memset(buf, 0, memsize);
>
> r->flags = IORESOURCE_MEM;
> r->start = dma_handle;
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.