2022-11-16 20:51:54

by Giulio Benetti

Subject: [PATCH v3 1/4] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets

Fix IMXRT1050_CLK_LCDIF_APB offsets.

Cc: Jesse Taube <[email protected]>
Signed-off-by: Giulio Benetti <[email protected]>
---
V1->V2:
* nothing done
V2->V3:
* added commit log and not only subject as suggested by Jesse Taube
---
drivers/clk/imx/clk-imxrt1050.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
index 9539d35588ee..26108e9f7e67 100644
--- a/drivers/clk/imx/clk-imxrt1050.c
+++ b/drivers/clk/imx/clk-imxrt1050.c
@@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev)
hws[IMXRT1050_CLK_USDHC1] = imx_clk_hw_gate2("usdhc1", "usdhc1_podf", ccm_base + 0x80, 2);
hws[IMXRT1050_CLK_USDHC2] = imx_clk_hw_gate2("usdhc2", "usdhc2_podf", ccm_base + 0x80, 4);
hws[IMXRT1050_CLK_LPUART1] = imx_clk_hw_gate2("lpuart1", "lpuart_podf", ccm_base + 0x7c, 24);
- hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x74, 10);
+ hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x70, 28);
hws[IMXRT1050_CLK_DMA] = imx_clk_hw_gate("dma", "ipg", ccm_base + 0x7C, 6);
hws[IMXRT1050_CLK_DMA_MUX] = imx_clk_hw_gate("dmamux0", "ipg", ccm_base + 0x7C, 7);
imx_check_clk_hws(hws, IMXRT1050_CLK_END);
--
2.34.1

2022-11-16 21:04:04

by Giulio Benetti

Subject: [PATCH v3 2/4] clk: imx: imxrt1050: add IMXRT1050_CLK_LCDIF_PIX clock gate

Add IMXRT1050_CLK_LCDIF_PIX clock gate.

Cc: Jesse Taube <[email protected]>
Signed-off-by: Giulio Benetti <[email protected]>
Acked-by: Jesse Taube <[email protected]>
---
V1->V2:
* nothing done
V2->V3:
* added commit log and not only subject as suggested by Jesse Taube
* added Jesse Taube's Acked-by:
---
drivers/clk/imx/clk-imxrt1050.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
index 26108e9f7e67..39f77c03b892 100644
--- a/drivers/clk/imx/clk-imxrt1050.c
+++ b/drivers/clk/imx/clk-imxrt1050.c
@@ -141,6 +141,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev)
hws[IMXRT1050_CLK_USDHC2] = imx_clk_hw_gate2("usdhc2", "usdhc2_podf", ccm_base + 0x80, 4);
hws[IMXRT1050_CLK_LPUART1] = imx_clk_hw_gate2("lpuart1", "lpuart_podf", ccm_base + 0x7c, 24);
hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x70, 28);
+ hws[IMXRT1050_CLK_LCDIF_PIX] = imx_clk_hw_gate2("lcdif_pix", "lcdif", ccm_base + 0x74, 10);
hws[IMXRT1050_CLK_DMA] = imx_clk_hw_gate("dma", "ipg", ccm_base + 0x7C, 6);
hws[IMXRT1050_CLK_DMA_MUX] = imx_clk_hw_gate("dmamux0", "ipg", ccm_base + 0x7C, 7);
imx_check_clk_hws(hws, IMXRT1050_CLK_END);
--
2.34.1

2022-11-16 21:04:47

by Giulio Benetti

Subject: [PATCH v3 4/4] ARM: dts: imx: prepend a 0 in the memory address to make it clear it's 32MB

Prepend a 0 in the memory address to make it clear it's 32MB

Cc: Jesse Taube <[email protected]>
Signed-off-by: Giulio Benetti <[email protected]>
Acked-by: Jesse Taube <[email protected]>
---
V1->V2:
* nothing done
V2->V3:
* added commit log and not only subject as suggested by Jesse Taube
* added Jesse Taube's Acked-by:
---
arch/arm/boot/dts/imxrt1050-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imxrt1050-evk.dts b/arch/arm/boot/dts/imxrt1050-evk.dts
index 1d339f48899f..3de392d014fe 100644
--- a/arch/arm/boot/dts/imxrt1050-evk.dts
+++ b/arch/arm/boot/dts/imxrt1050-evk.dts
@@ -28,7 +28,7 @@ aliases {

memory@80000000 {
device_type = "memory";
- reg = <0x80000000 0x2000000>;
+ reg = <0x80000000 0x02000000>;
};

panel {
--
2.34.1

2022-11-16 21:19:41

by Giulio Benetti

Subject: Re: [PATCH v3 1/4] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets

Hi Fabio,

On 16/11/22 21:52, Fabio Estevam wrote:
> Hi Giulio,
>
> On Wed, Nov 16, 2022 at 5:35 PM Giulio Benetti
> <[email protected]> wrote:
>>
>> Fix IMXRT1050_CLK_LCDIF_APB offsets.
>>
>> Cc: Jesse Taube <[email protected]>
>> Signed-off-by: Giulio Benetti <[email protected]>
>
> Since this is a fix, please add a Fixes tag.

Fixes: 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 clock
driver")

Do you want me to send a V4 for these patches with the Fixes tag?

Best regards
--
Giulio Benetti
CEO/CTO@Benetti Engineering sas

2022-11-16 21:37:13

by Fabio Estevam

Subject: Re: [PATCH v3 1/4] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets

Hi Giulio,

On Wed, Nov 16, 2022 at 5:35 PM Giulio Benetti
<[email protected]> wrote:
>
> Fix IMXRT1050_CLK_LCDIF_APB offsets.
>
> Cc: Jesse Taube <[email protected]>
> Signed-off-by: Giulio Benetti <[email protected]>

Since this is a fix, please add a Fixes tag.