2019-08-09 04:02:01

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the block tree

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
struct nvm_geo *geo = &dev->geo;
^~~

Introduced by commit

ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")

Removing the above line will also remove the last use of the variable
"dev" ...
--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-08-09 04:14:57

by Jens Axboe

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the block tree

On 8/8/19 9:00 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
> struct nvm_geo *geo = &dev->geo;
> ^~~
>
> Introduced by commit
>
> ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
>
> Removing the above line will also remove the last use of the variable
> "dev" ...

Thanks, will fix it up.

--
Jens Axboe

2019-08-09 06:17:34

by Yue Haibing

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the block tree

On 2019/8/9 12:00, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
> struct nvm_geo *geo = &dev->geo;
> ^~~
>
> Introduced by commit
>
> ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
>
> Removing the above line will also remove the last use of the variable
> "dev" ...

Oh, my bad, thanks!

>