2022-11-03 18:18:29

by Randy Dunlap

[permalink] [raw]
Subject: staging: rtl8192e: build warning on HZ

FYI:

When CONFIG_HZ=24 (arch/mips/):

../drivers/staging/rtl8192e/rtllib_wx.c: In function 'rtl819x_translate_scan':
../drivers/staging/rtl8192e/rtllib_wx.c:220:57: warning: division by zero [-Wdiv-by-zero]
220 | (jiffies - network->last_scanned) / (HZ / 100));
| ^
In file included from ../include/linux/skbuff.h:45,
from ../include/linux/if_ether.h:19,
from ../include/linux/etherdevice.h:20,
from ../drivers/staging/rtl8192e/rtllib_wx.c:18:
../drivers/staging/rtl8192e/rtllib_wx.c: In function 'rtllib_wx_get_scan':
../drivers/staging/rtl8192e/rtllib_wx.c:261:70: warning: division by zero [-Wdiv-by-zero]
261 | (jiffies - network->last_scanned) /
|

--
~Randy


2022-11-03 19:39:34

by Larry Finger

[permalink] [raw]
Subject: Re: staging: rtl8192e: build warning on HZ

On 11/3/22 13:07, Randy Dunlap wrote:
> FYI:
>
> When CONFIG_HZ=24 (arch/mips/):
>
> ../drivers/staging/rtl8192e/rtllib_wx.c: In function 'rtl819x_translate_scan':
> ../drivers/staging/rtl8192e/rtllib_wx.c:220:57: warning: division by zero [-Wdiv-by-zero]
> 220 | (jiffies - network->last_scanned) / (HZ / 100));
> | ^
> In file included from ../include/linux/skbuff.h:45,
> from ../include/linux/if_ether.h:19,
> from ../include/linux/etherdevice.h:20,
> from ../drivers/staging/rtl8192e/rtllib_wx.c:18:
> ../drivers/staging/rtl8192e/rtllib_wx.c: In function 'rtllib_wx_get_scan':
> ../drivers/staging/rtl8192e/rtllib_wx.c:261:70: warning: division by zero [-Wdiv-by-zero]
> 261 | (jiffies - network->last_scanned) /
> |

That statement is messed up. Does the attached patch fix it?


Larry


Attachments:
test_patch_fr_rtl8192e.patch (688.00 B)