2022-04-23 08:55:59

by Karthik Alapati

Subject: [PATCH] selftests/binderfs: Improve message to provide more info

Currently the binderfs test says what failure it encountered
without saying why it may occurred when it fails to mount
binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
running kernel.

Signed-off-by: Karthik Alapati <[email protected]>
---
tools/testing/selftests/filesystems/binderfs/binderfs_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
index 0315955ff0f4..bc1c407651fc 100644
--- a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
+++ b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
@@ -412,7 +412,8 @@ TEST(binderfs_stress)

ret = mount(NULL, binderfs_mntpt, "binder", 0, 0);
ASSERT_EQ(ret, 0) {
- TH_LOG("%s - Failed to mount binderfs", strerror(errno));
+ TH_LOG("%s - Failed to mount binderfs, check if CONFIG_ANDROID_BINDERFS is enabled in the running kernel",
+ strerror(errno));
}

for (int i = 0; i < ARRAY_SIZE(fds); i++) {
--
2.35.2

2022-04-25 11:29:18

by Christian Brauner

Subject: Re: [PATCH] selftests/binderfs: Improve message to provide more info

On Sat, Apr 23, 2022 at 11:14:34AM +0530, Karthik Alapati wrote:
> Currently the binderfs test says what failure it encountered
> without saying why it may occurred when it fails to mount
> binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
> running kernel.
>
> Signed-off-by: Karthik Alapati <[email protected]>
> ---

Reviewed-by: Christian Brauner (Microsoft) <[email protected]>

2022-04-26 05:41:51

by Shuah Khan

Subject: Re: [PATCH] selftests/binderfs: Improve message to provide more info

On 4/25/22 3:49 AM, Christian Brauner wrote:
> On Sat, Apr 23, 2022 at 11:14:34AM +0530, Karthik Alapati wrote:
>> Currently the binderfs test says what failure it encountered
>> without saying why it may occurred when it fails to mount
>> binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
>> running kernel.
>>
>> Signed-off-by: Karthik Alapati <[email protected]>
>> ---
>
> Reviewed-by: Christian Brauner (Microsoft) <[email protected]>
>

Thank you both - I will apply this for next to be included in
Linux 5.19-rc1

thanks,
-- Shuah