2021-08-13 10:43:53

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the block tree

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'

Introduced by commit

1cbbd31c4ada ("bio: add allocation cache abstraction")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-08-13 14:28:57

by Jens Axboe

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the block tree

On 8/13/21 3:41 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'
>
> Introduced by commit
>
> 1cbbd31c4ada ("bio: add allocation cache abstraction")

Thanks, fixed up.

--
Jens Axboe

2021-09-03 07:51:09

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the block tree

Hi Jens,

On Fri, 13 Aug 2021 07:54:51 -0600 Jens Axboe <[email protected]> wrote:
>
> On 8/13/21 3:41 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the block tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'
> >
> > Introduced by commit
> >
> > 1cbbd31c4ada ("bio: add allocation cache abstraction")
>
> Thanks, fixed up.

Not really :-( I am now also getting this (the above has moved to line
1704 as well):

block/bio.c:1704: warning: Excess function parameter 'nr_iovecs' description in 'bio_alloc_kiocb'

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-09-03 14:04:50

by Jens Axboe

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the block tree

On 9/3/21 12:49 AM, Stephen Rothwell wrote:
> Hi Jens,
>
> On Fri, 13 Aug 2021 07:54:51 -0600 Jens Axboe <[email protected]> wrote:
>>
>> On 8/13/21 3:41 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the block tree, today's linux-next build (htmldocs)
>>> produced this warning:
>>>
>>> block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'
>>>
>>> Introduced by commit
>>>
>>> 1cbbd31c4ada ("bio: add allocation cache abstraction")
>>
>> Thanks, fixed up.
>
> Not really :-( I am now also getting this (the above has moved to line
> 1704 as well):
>
> block/bio.c:1704: warning: Excess function parameter 'nr_iovecs' description in 'bio_alloc_kiocb'

This should fix that one up:

diff --git a/block/bio.c b/block/bio.c
index e16849f46b0e..5df3dd282e40 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1688,7 +1688,7 @@ EXPORT_SYMBOL(bioset_init_from_src);
/**
* bio_alloc_kiocb - Allocate a bio from bio_set based on kiocb
* @kiocb: kiocb describing the IO
- * @nr_iovecs: number of iovecs to pre-allocate
+ * @nr_vecs: number of iovecs to pre-allocate
* @bs: bio_set to allocate from
*
* Description:

--
Jens Axboe