2022-11-04 13:36:34

by Vincent Knecht

Subject: [PATCH v2 1/3] arm64: dts: qcom: msm8916-alcatel-idol347: Add GPIOs -state suffix

Add -state suffix to GPIOs states node names as required by dt-bindings.

Signed-off-by: Vincent Knecht <[email protected]>
---
.../boot/dts/qcom/msm8916-alcatel-idol347.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
index 3dc9619fde6e..668f8ff53229 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
@@ -260,7 +260,7 @@ l18 {
};

&msmgpio {
- accel_int_default: accel-int-default {
+ accel_int_default: accel-int-default-state {
pins = "gpio31";
function = "gpio";

@@ -268,7 +268,7 @@ accel_int_default: accel-int-default {
bias-disable;
};

- gpio_keys_default: gpio-keys-default {
+ gpio_keys_default: gpio-keys-default-state {
pins = "gpio107";
function = "gpio";

@@ -276,7 +276,7 @@ gpio_keys_default: gpio-keys-default {
bias-pull-up;
};

- gyro_int_default: gyro-int-default {
+ gyro_int_default: gyro-int-default-state {
pins = "gpio97", "gpio98";
function = "gpio";

@@ -284,7 +284,7 @@ gyro_int_default: gyro-int-default {
bias-disable;
};

- mag_reset_default: mag-reset-default {
+ mag_reset_default: mag-reset-default-state {
pins = "gpio8";
function = "gpio";

@@ -292,7 +292,7 @@ mag_reset_default: mag-reset-default {
bias-disable;
};

- proximity_int_default: proximity-int-default {
+ proximity_int_default: proximity-int-default-state {
pins = "gpio12";
function = "gpio";

@@ -300,7 +300,7 @@ proximity_int_default: proximity-int-default {
bias-pull-up;
};

- ts_int_reset_default: ts-int-reset-default {
+ ts_int_reset_default: ts-int-reset-default-state {
pins = "gpio13", "gpio100";
function = "gpio";

@@ -308,7 +308,7 @@ ts_int_reset_default: ts-int-reset-default {
bias-disable;
};

- usb_id_default: usb-id-default {
+ usb_id_default: usb-id-default-state {
pins = "gpio69";
function = "gpio";

--
2.38.1

2022-11-04 14:13:46

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: msm8916-alcatel-idol347: Add GPIOs -state suffix

On 04/11/2022 09:23, Vincent Knecht wrote:
> Add -state suffix to GPIOs states node names as required by dt-bindings.
>
> Signed-off-by: Vincent Knecht <[email protected]>
> ---
> .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 14 +++++++-------

This was fixed:

https://lore.kernel.org/all/[email protected]/

Best regards,
Krzysztof

2022-11-04 14:24:02

by Konrad Dybcio

Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: msm8916-alcatel-idol347: Add GPIOs -state suffix

On 04/11/2022 14:23, Vincent Knecht wrote:
> Add -state suffix to GPIOs states node names as required by dt-bindings.
>
> Signed-off-by: Vincent Knecht <[email protected]>
> ---

Reviewed-by Konrad Dybcio <[email protected]>


Konrad

> .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> index 3dc9619fde6e..668f8ff53229 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> @@ -260,7 +260,7 @@ l18 {
> };
>
> &msmgpio {
> - accel_int_default: accel-int-default {
> + accel_int_default: accel-int-default-state {
> pins = "gpio31";
> function = "gpio";
>
> @@ -268,7 +268,7 @@ accel_int_default: accel-int-default {
> bias-disable;
> };
>
> - gpio_keys_default: gpio-keys-default {
> + gpio_keys_default: gpio-keys-default-state {
> pins = "gpio107";
> function = "gpio";
>
> @@ -276,7 +276,7 @@ gpio_keys_default: gpio-keys-default {
> bias-pull-up;
> };
>
> - gyro_int_default: gyro-int-default {
> + gyro_int_default: gyro-int-default-state {
> pins = "gpio97", "gpio98";
> function = "gpio";
>
> @@ -284,7 +284,7 @@ gyro_int_default: gyro-int-default {
> bias-disable;
> };
>
> - mag_reset_default: mag-reset-default {
> + mag_reset_default: mag-reset-default-state {
> pins = "gpio8";
> function = "gpio";
>
> @@ -292,7 +292,7 @@ mag_reset_default: mag-reset-default {
> bias-disable;
> };
>
> - proximity_int_default: proximity-int-default {
> + proximity_int_default: proximity-int-default-state {
> pins = "gpio12";
> function = "gpio";
>
> @@ -300,7 +300,7 @@ proximity_int_default: proximity-int-default {
> bias-pull-up;
> };
>
> - ts_int_reset_default: ts-int-reset-default {
> + ts_int_reset_default: ts-int-reset-default-state {
> pins = "gpio13", "gpio100";
> function = "gpio";
>
> @@ -308,7 +308,7 @@ ts_int_reset_default: ts-int-reset-default {
> bias-disable;
> };
>
> - usb_id_default: usb-id-default {
> + usb_id_default: usb-id-default-state {
> pins = "gpio69";
> function = "gpio";
>