2024-01-10 09:11:09

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes

On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann <[email protected]> wrote:
> From: Arnd Bergmann <[email protected]>
>
> The prototype was hidden in an #ifdef on x86, which causes a warning:
>
> kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]

This issue is now present upstream.

> Some architectures have a working prototype, while others don't.
> Fix this by providing it in only one place that is always visible.
>
> Acked-by: Catalin Marinas <[email protected]>
> Acked-by: Palmer Dabbelt <[email protected]>
> Acked-by: Guo Ren <[email protected]>
> Reviewed-by: Alexander Gordeev <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>

Tested-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2024-01-10 10:24:39

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes

On Wed, Jan 10, 2024, at 10:03, Geert Uytterhoeven wrote:
> On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann <[email protected]> wrote:
>> From: Arnd Bergmann <[email protected]>
>>
>> The prototype was hidden in an #ifdef on x86, which causes a warning:
>>
>> kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]
>
> This issue is now present upstream.
>
>> Some architectures have a working prototype, while others don't.
>> Fix this by providing it in only one place that is always visible.
>>
>> Acked-by: Catalin Marinas <[email protected]>
>> Acked-by: Palmer Dabbelt <[email protected]>
>> Acked-by: Guo Ren <[email protected]>
>> Reviewed-by: Alexander Gordeev <[email protected]>
>> Signed-off-by: Arnd Bergmann <[email protected]>
>
> Tested-by: Geert Uytterhoeven <[email protected]>

I've sent out the asm-generic pull request now,
that contains the fix. Thanks for the reminder.

Arnd