2019-03-16 23:12:21

by Colin King

Subject: [PATCH] IB/iser: remove uninitialized variable len

From: Colin Ian King <[email protected]>

The variable len is not being inintialized and the uninitialized
value is being returned. However, this return path is never reached
because the default case in the switch statement returns -ENOSYS.
Clean up the code by replacing the return -ENOSYS with a break
for the default case and returning -ENOSYS at the end of the
function. This allows len to be removed. Also remove redundant
break that follows a return statement.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 8c707accd148..9c185a8dabd3 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -763,7 +763,6 @@ static int iscsi_iser_get_ep_param(struct iscsi_endpoint *ep,
enum iscsi_param param, char *buf)
{
struct iser_conn *iser_conn = ep->dd_data;
- int len;

switch (param) {
case ISCSI_PARAM_CONN_PORT:
@@ -774,12 +773,10 @@ static int iscsi_iser_get_ep_param(struct iscsi_endpoint *ep,
return iscsi_conn_get_addr_param((struct sockaddr_storage *)
&iser_conn->ib_conn.cma_id->route.addr.dst_addr,
param, buf);
- break;
default:
- return -ENOSYS;
+ break;
}
-
- return len;
+ return -ENOSYS;
}

/**
--
2.20.1

2019-03-17 10:06:29

by Max Gurtovoy

Subject: Re: [PATCH] IB/iser: remove uninitialized variable len

On 3/17/2019 1:05 AM, Colin King wrote:
> From: Colin Ian King<[email protected]>
>
> The variable len is not being inintialized and the uninitialized
> value is being returned. However, this return path is never reached
> because the default case in the switch statement returns -ENOSYS.
> Clean up the code by replacing the return -ENOSYS with a break
> for the default case and returning -ENOSYS at the end of the
> function. This allows len to be removed. Also remove redundant
> break that follows a return statement.
>
> Signed-off-by: Colin Ian King<[email protected]>

Looks good,

Reviewed-by: Max Gurtovoy <[email protected]>

2019-03-18 21:47:33

by Sagi Grimberg

Subject: Re: [PATCH] IB/iser: remove uninitialized variable len

Reviewed-by: Sagi Grimberg <[email protected]>

2019-03-27 13:23:22

by Jason Gunthorpe

Subject: Re: [PATCH] IB/iser: remove uninitialized variable len

On Sat, Mar 16, 2019 at 11:05:12PM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable len is not being inintialized and the uninitialized
> value is being returned. However, this return path is never reached
> because the default case in the switch statement returns -ENOSYS.
> Clean up the code by replacing the return -ENOSYS with a break
> for the default case and returning -ENOSYS at the end of the
> function. This allows len to be removed. Also remove redundant
> break that follows a return statement.
>
> Signed-off-by: Colin Ian King <[email protected]>
> Reviewed-by: Max Gurtovoy <[email protected]>
> Reviewed-by: Sagi Grimberg <[email protected]>
> ---
> drivers/infiniband/ulp/iser/iscsi_iser.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)

Applied to for-next

Thanks,
Jason