2017-11-29 22:49:40

by Henrik Rydberg

Subject: Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting

On 10/12/2017 08:21 AM, Wei-Ning Huang wrote:
> From: Wei-Ning Huang <[email protected]>
>
> The current hid-multitouch driver only allow the report of two
> orientations, vertical and horizontal. We use the Azimuth orientation
> usage 0x3F under the Digitizer usage page to report orientation if the
> device supports it.
>
> Changelog:
> v1 -> v2:
> - Fix commit message.
> - Remove resolution reporting for ABS_MT_ORIENTATION.
> v2 -> v3:
> - Fix commit message.
> v3 -> v4:
> - Fix ABS_MT_ORIENTATION ABS param range.
> - Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already
> set by ABS_DG_AZIMUTH.
> v4 -> v5:
> - Improve multi-touch-protocol.rst documentation.
>
> Signed-off-by: Wei-Ning Huang <[email protected]>
> Signed-off-by: Wei-Ning Huang <[email protected]>
> Reviewed-by: Dmitry Torokhov <[email protected]>
> ---
> Documentation/input/multi-touch-protocol.rst | 9 ++---
> drivers/hid/hid-multitouch.c | 52 +++++++++++++++++++++++++---
> include/linux/hid.h | 1 +
> 3 files changed, 54 insertions(+), 8 deletions(-)

   Reviewed-by: Henrik Rydberg <[email protected]>

Thank you, Wei-Ning, and sorry for the delay. Dmitry, did you plan to
add this to your pull request already?

Henrik


From 1585441920454326874@xxx Wed Nov 29 22:40:39 +0000 2017
X-GM-THRID: 1581031818844880283
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-29 22:40:40

by Dmitry Torokhov

Subject: Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting

On Wed, Nov 29, 2017 at 11:33:58PM +0100, Henrik Rydberg wrote:
> On 10/12/2017 08:21 AM, Wei-Ning Huang wrote:
> > From: Wei-Ning Huang <[email protected]>
> >
> > The current hid-multitouch driver only allow the report of two
> > orientations, vertical and horizontal. We use the Azimuth orientation
> > usage 0x3F under the Digitizer usage page to report orientation if the
> > device supports it.
> >
> > Changelog:
> > v1 -> v2:
> > - Fix commit message.
> > - Remove resolution reporting for ABS_MT_ORIENTATION.
> > v2 -> v3:
> > - Fix commit message.
> > v3 -> v4:
> > - Fix ABS_MT_ORIENTATION ABS param range.
> > - Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already
> > set by ABS_DG_AZIMUTH.
> > v4 -> v5:
> > - Improve multi-touch-protocol.rst documentation.
> >
> > Signed-off-by: Wei-Ning Huang <[email protected]>
> > Signed-off-by: Wei-Ning Huang <[email protected]>
> > Reviewed-by: Dmitry Torokhov <[email protected]>
> > ---
> > Documentation/input/multi-touch-protocol.rst | 9 ++---
> > drivers/hid/hid-multitouch.c | 52 +++++++++++++++++++++++++---
> > include/linux/hid.h | 1 +
> > 3 files changed, 54 insertions(+), 8 deletions(-)
>
> �� Reviewed-by: Henrik Rydberg <[email protected]>
>
> Thank you, Wei-Ning, and sorry for the delay. Dmitry, did you plan to add
> this to your pull request already?

This should go through Jiri's tree as it is all HID stuff.

Thanks.

--
Dmitry

From 1581032286226620268@xxx Thu Oct 12 06:31:24 +0000 2017
X-GM-THRID: 1581031818844880283
X-Gmail-Labels: Inbox,Category Forums