2018-01-12 14:07:59

by Pavel Vazharov

Subject: [PATCH] bcache: io.c: Fix check against error_limit in case of io errors

The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT
times before it is stored in the error_limit.
This fixes the un-registering of the cache set when the io_errors reach
the error_limit value.

Signed-off-by: Pavel Vazharov <[email protected]>
---
drivers/md/bcache/io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c
index fac97ec..1ef6ae2 100644
--- a/drivers/md/bcache/io.c
+++ b/drivers/md/bcache/io.c
@@ -93,7 +93,7 @@ void bch_count_io_errors(struct cache *ca, blk_status_t error, const char *m)
&ca->io_errors);
errors >>= IO_ERROR_SHIFT;

- if (errors < ca->set->error_limit)
+ if (errors < (ca->set->error_limit >> IO_ERROR_SHIFT))
pr_err("%s: IO error on %s, recovering",
bdevname(ca->bdev, buf), m);
else
--
2.7.4

2018-01-13 03:41:03

by Coly Li

Subject: Re: [PATCH] bcache: io.c: Fix check against error_limit in case of io errors

On 12/01/2018 10:07 PM, Pavel Vazharov wrote:
> The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT
> times before it is stored in the error_limit.
> This fixes the un-registering of the cache set when the io_errors reach
> the error_limit value.
>
> Signed-off-by: Pavel Vazharov <[email protected]>
> ---
> drivers/md/bcache/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c
> index fac97ec..1ef6ae2 100644
> --- a/drivers/md/bcache/io.c
> +++ b/drivers/md/bcache/io.c
> @@ -93,7 +93,7 @@ void bch_count_io_errors(struct cache *ca, blk_status_t error, const char *m)
> &ca->io_errors);
> errors >>= IO_ERROR_SHIFT;
>
> - if (errors < ca->set->error_limit)
> + if (errors < (ca->set->error_limit >> IO_ERROR_SHIFT))
> pr_err("%s: IO error on %s, recovering",
> bdevname(ca->bdev, buf), m);
> else
>

Hi Pavel,

A similar fix is also in my device failure patch set, its name is,
bcache: set error_limit correctly
The difference is, I remove the bit shift of error_limit.

--
Coly Li

2018-01-13 04:22:29

by Pavel Vazharov

Subject: Re: [PATCH] bcache: io.c: Fix check against error_limit in case of io errors

On Sat, 13 Jan 2018 11:40:54 +0800
Coly Li <[email protected]> wrote:

> On 12/01/2018 10:07 PM, Pavel Vazharov wrote:
> > The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT
> > times before it is stored in the error_limit.
> > This fixes the un-registering of the cache set when the io_errors reach
> > the error_limit value.
> >
> > Signed-off-by: Pavel Vazharov <[email protected]>
> > ---
> > drivers/md/bcache/io.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c
> > index fac97ec..1ef6ae2 100644
> > --- a/drivers/md/bcache/io.c
> > +++ b/drivers/md/bcache/io.c
> > @@ -93,7 +93,7 @@ void bch_count_io_errors(struct cache *ca, blk_status_t error, const char *m)
> > &ca->io_errors);
> > errors >>= IO_ERROR_SHIFT;
> >
> > - if (errors < ca->set->error_limit)
> > + if (errors < (ca->set->error_limit >> IO_ERROR_SHIFT))
> > pr_err("%s: IO error on %s, recovering",
> > bdevname(ca->bdev, buf), m);
> > else
> >
>
> Hi Pavel,
>
> A similar fix is also in my device failure patch set, its name is,
> bcache: set error_limit correctly
> The difference is, I remove the bit shift of error_limit.
>
> --
> Coly Li

Hi Coly,

I see your patch. I think it's better solution.
Originally, I was wondering why the shifting of error_limit is needed
when it's set via sysfs just to shift it back here.

--
Pavel Vazharov <[email protected]>