2018-11-12 09:06:46

by Malathi Gottam

Subject: [PATCH] media: venus: change the default value of GOP size

When the client doesn't explicitly set any GOP size, current
default value is low and overshoots bitrate beyond tolerance.
Hence default value is modified so as to have intra period of 1sec.

Signed-off-by: Malathi Gottam <[email protected]>
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c
index 45910172..e6a43e9 100644
--- a/drivers/media/platform/qcom/venus/venc_ctrls.c
+++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
@@ -295,7 +295,7 @@ int venc_ctrl_init(struct venus_inst *inst)
0, INTRA_REFRESH_MBS_MAX, 1, 0);

v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
- V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 12);
+ V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);

v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
V4L2_CID_MPEG_VIDEO_VPX_MIN_QP, 1, 128, 1, 1);
--
1.9.1

2018-11-12 11:53:09

by Stanimir Varbanov

Subject: Re: [PATCH] media: venus: change the default value of GOP size

Hi Malathi,

Thanks for the patch!

On 11/12/18 11:06 AM, Malathi Gottam wrote:
> When the client doesn't explicitly set any GOP size, current
> default value is low and overshoots bitrate beyond tolerance.
> Hence default value is modified so as to have intra period of 1sec.
>
> Signed-off-by: Malathi Gottam <[email protected]>
> ---
> drivers/media/platform/qcom/venus/venc_ctrls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Sounds reasonable :

Acked-by: Stanimir Varbanov <[email protected]>

> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c
> index 45910172..e6a43e9 100644
> --- a/drivers/media/platform/qcom/venus/venc_ctrls.c
> +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
> @@ -295,7 +295,7 @@ int venc_ctrl_init(struct venus_inst *inst)
> 0, INTRA_REFRESH_MBS_MAX, 1, 0);
>
> v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
> - V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 12);
> + V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);
>
> v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
> V4L2_CID_MPEG_VIDEO_VPX_MIN_QP, 1, 128, 1, 1);
>

--
regards,
Stan