2023-11-27 09:32:43

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Add DSS support for TI AM62A7 SoC

Hi,

On 08/11/2023 19:16, Aradhya Bhatia wrote:
> This patch series adds a new compatible for the Display SubSystem (DSS)
> controller on TI's AM62A7 SoC. It further adds the required support, for
> the same, in the tidss driver.
>
> The DSS controller is similar to the recently added AM625 DSS, with the
> key difference being the absence of VP1 output on the SoC. The VP1 in
> AM62A7 DSS is tied off and cannot be used, unlike in AM625, where the
> VP1 was connected to 2 OLDI TXes. The video pipeline that corresponds to
> VP1 still exists and can be used to overlay planes on the VP2's primary
> plane. This can be done using the overlay managers inside the SoC.
> Moreover, DSS VP2 can output Full-HD RGB888 DPI video signals.
>
> I have tested these patches on AM62A7 SK-EVM, which converts DPI signals
> to HDMI on the platform using the Sil9022A HDMI transmitter. All the
> patches, required to enable display on AM62A7-SK, can be found on my
> github fork[0] in the branch "next_am62a-v3".
>
> Regards
> Aradhya
>
> [0]: https://github.com/aradhya07/linux-ab/tree/next_am62a-v3
>
> Change Log:
> V2 -> V3:
> - Add Krzysztof Kozlowski's R-b in patch 1/2.
> - Add new DISPC_VP_TIED_OFF for tied-off video-ports in patch 2/2.
>
> V1 -> V2:
> - Correctly sort DISPC_AM62A7 macro after DISPC_AM625 in patch 2/2.
>
> Previous Versions:
> V1: https://lore.kernel.org/all/[email protected]/
> V2: https://lore.kernel.org/all/[email protected]/
>
> Aradhya Bhatia (2):
> dt-bindings: display: ti: Add support for am62a7 dss
> drivers/tidss: Add support for AM62A7 DSS
>
> .../bindings/display/ti/ti,am65x-dss.yaml | 14 +++++
> drivers/gpu/drm/tidss/tidss_dispc.c | 59 +++++++++++++++++++
> drivers/gpu/drm/tidss/tidss_dispc.h | 3 +
> drivers/gpu/drm/tidss/tidss_drv.c | 1 +
> 4 files changed, 77 insertions(+)
>
>
> base-commit: 2220f68f4504aa1ccce0fac721ccdb301e9da32f

For the series:

Reviewed-by: Tomi Valkeinen <[email protected]>

Tomi