Hi John,
On 06/05/2024 00:26, John Hubbard wrote:
> When building with clang, via:
>
> make LLVM=1 -C tools/testing/selftest
>
> ...clang warns about three variables that are not initialized in all
> cases:
>
> 1) The opt_ipproto_off variable is used uninitialized if "testname" is
> not "ip". This seems like an actual bug.
>
> 2) The addr_len is used uninitialized, but only in the assert case,
> which bails out, so this is harmless.
>
> 3) The family variable in add_listener() is only used uninitialized in
> the error case (neither IPv4 nor IPv6 is specified), so it's also
> harmless.
>
> Fix by initializing each variable.
>
> Signed-off-by: John Hubbard <[email protected]>
> ---
> tools/testing/selftests/net/gro.c | 3 ++-
> tools/testing/selftests/net/ip_local_port_range.c | 2 +-
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 2 +-
Thank you for fixing these warnings!
The modification in the MPTCP selftest directory looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <[email protected]>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.