2024-05-27 05:22:32

by hexue

Subject: [PATCH] block: delete redundant function declarations

From: Xue He <[email protected]>

It is used in block hybrid poll, the related function
definitions have been removed, but the function
declaration has not been delelted.

Signed-off-by: Xue He <[email protected]>
---
block/blk-stat.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/block/blk-stat.h b/block/blk-stat.h
index 17e1eb4ec7e2..5d7f18ba436d 100644
--- a/block/blk-stat.h
+++ b/block/blk-stat.h
@@ -64,7 +64,6 @@ struct blk_stat_callback {

struct blk_queue_stats *blk_alloc_queue_stats(void);
void blk_free_queue_stats(struct blk_queue_stats *);
-bool blk_stats_alloc_enable(struct request_queue *q);

void blk_stat_add(struct request *rq, u64 now);

--
2.40.1

2024-05-27 05:40:30

by Kanchan Joshi

Subject: Re: [PATCH] block: delete redundant function declarations

On 5/27/2024 7:59 AM, hexue wrote:
> From: Xue He <[email protected]>
>
> It is used in block hybrid poll, the related function

It -> blk_stats_alloc_enable

Also, you might want to mention the patch that removed it.
54bdd67d0f88 blk-mq: remove hybrid polling


> definitions have been removed, but the function
> declaration has not been delelted.
delelted -> deleted.

2024-05-27 08:40:32

by hexue

Subject: Re: Re: [PATCH] block: delete redundant function declarations

On 5/27/2024 11:09 AM, Kanchan Joshi wrote:
>On 5/27/2024 7:59 AM, hexue wrote:
>> From: Xue He <[email protected]>
>>
>> It is used in block hybrid poll, the related function
>
>It -> blk_stats_alloc_enable
>
>Also, you might want to mention the patch that removed it.
>54bdd67d0f88 blk-mq: remove hybrid polling
>
>
>> definitions have been removed, but the function
>> declaration has not been delelted.
>delelted -> deleted.

Thanks, will modify these and submit v2.