2023-12-07 09:27:25

by Suraj Jaiswal

Subject: [PATCH net-next v4 1/3] dt-bindings: net: qcom,ethqos: add binding doc for safety IRQ for sa8775p

Add binding doc for safety IRQ. The safety IRQ will be
triggered for ECC, DPP, FSM error.

Signed-off-by: Suraj Jaiswal <[email protected]>
---
Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 9 ++++++---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++++--
2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 7bdb412a0185..93d21389e518 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -37,12 +37,14 @@ properties:
items:
- description: Combined signal for various interrupt events
- description: The interrupt that occurs when Rx exits the LPI state
+ - description: The interrupt that occurs when HW safety error triggered

interrupt-names:
minItems: 1
items:
- const: macirq
- - const: eth_lpi
+ - enum: [eth_lpi, safety]
+ - const: safety

clocks:
maxItems: 4
@@ -89,8 +91,9 @@ examples:
<&gcc GCC_ETH_PTP_CLK>,
<&gcc GCC_ETH_RGMII_CLK>;
interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "macirq", "eth_lpi";
+ <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "macirq", "eth_lpi", "safety";

rx-fifo-depth = <4096>;
tx-fifo-depth = <4096>;
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 5c2769dc689a..3b46d69ea97d 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -107,13 +107,15 @@ properties:
- description: Combined signal for various interrupt events
- description: The interrupt to manage the remote wake-up packet detection
- description: The interrupt that occurs when Rx exits the LPI state
+ - description: The interrupt that occurs when HW safety error triggered

interrupt-names:
minItems: 1
items:
- const: macirq
- - enum: [eth_wake_irq, eth_lpi]
- - const: eth_lpi
+ - enum: [eth_wake_irq, eth_lpi, safety]
+ - enum: [eth_wake_irq, eth_lpi, safety]
+ - enum: [eth_wake_irq, eth_lpi, safety]

clocks:
minItems: 1
--
2.25.1

2023-12-08 20:37:16

by Rob Herring (Arm)

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: qcom,ethqos: add binding doc for safety IRQ for sa8775p

On Thu, 07 Dec 2023 14:51:25 +0530, Suraj Jaiswal wrote:
> Add binding doc for safety IRQ. The safety IRQ will be
> triggered for ECC, DPP, FSM error.
>
> Signed-off-by: Suraj Jaiswal <[email protected]>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 9 ++++++---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++++--
> 2 files changed, 10 insertions(+), 5 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2023-12-09 17:47:17

by Konrad Dybcio

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: qcom,ethqos: add binding doc for safety IRQ for sa8775p

On 7.12.2023 10:21, Suraj Jaiswal wrote:
> Add binding doc for safety IRQ. The safety IRQ will be
> triggered for ECC, DPP, FSM error.
ECC is widely understood, but the DPP and FSM acronyms could be
expanded..

Konrad

2023-12-11 05:24:37

by Suraj Jaiswal

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: qcom,ethqos: add binding doc for safety IRQ for sa8775p

Sure . will expand below .


On 12/9/2023 11:17 PM, Konrad Dybcio wrote:
> On 7.12.2023 10:21, Suraj Jaiswal wrote:
>> Add binding doc for safety IRQ. The safety IRQ will be
>> triggered for ECC, DPP, FSM error.
> ECC is widely understood, but the DPP and FSM acronyms could be
> expanded..
>
> Konrad