2022-03-28 09:37:38

by Sameer Pujar

Subject: [RFC PATCH v2 2/6] ASoC: dt-bindings: Add audio-graph-port bindings to rt5659

To use rt5658 or rt5659 audio CODEC with generic audio-graph-card machine
driver, the CODEC requires "port" bindings. Thus add "audio-graph-port"
reference to the rt5659 binding.

Signed-off-by: Sameer Pujar <[email protected]>
Cc: Oder Chiou <[email protected]>
---
Documentation/devicetree/bindings/sound/realtek,rt5659.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
index 3bd9b6f..b0485b8 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
@@ -84,6 +84,10 @@ properties:

sound-name-prefix: true

+ port:
+ $ref: audio-graph-port.yaml#
+ unevaluatedProperties: false
+
additionalProperties: false

required:
--
2.7.4

2022-03-28 20:29:44

by Sameer Pujar

Subject: Re: [RFC PATCH v2 2/6] ASoC: dt-bindings: Add audio-graph-port bindings to rt5659

On 28-03-2022 12:33, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 28/03/2022 08:14, Sameer Pujar wrote:
>> To use rt5658 or rt5659 audio CODEC with generic audio-graph-card machine
>> driver, the CODEC requires "port" bindings. Thus add "audio-graph-port"
>> reference to the rt5659 binding.
>>
>> Signed-off-by: Sameer Pujar <[email protected]>
>> Cc: Oder Chiou <[email protected]>
>> ---
>> Documentation/devicetree/bindings/sound/realtek,rt5659.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
> This should be squashed with your previous patch, otherwise that one is
> not a complete conversion.
>
OK. I will squash this. Thanks.

2022-03-28 21:48:30

by Krzysztof Kozlowski

Subject: Re: [RFC PATCH v2 2/6] ASoC: dt-bindings: Add audio-graph-port bindings to rt5659

On 28/03/2022 08:14, Sameer Pujar wrote:
> To use rt5658 or rt5659 audio CODEC with generic audio-graph-card machine
> driver, the CODEC requires "port" bindings. Thus add "audio-graph-port"
> reference to the rt5659 binding.
>
> Signed-off-by: Sameer Pujar <[email protected]>
> Cc: Oder Chiou <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/realtek,rt5659.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

This should be squashed with your previous patch, otherwise that one is
not a complete conversion.

Best regards,
Krzysztof