2010-04-07 16:56:46

by jing zhang

[permalink] [raw]
Subject: Re: [PATCH] ext4: BUG_ON could be triggered in ext4_mb_normalize_request()

2010/4/7, [email protected] <[email protected]>:
> On Wed, Apr 07, 2010 at 09:51:46PM +0800, jing zhang wrote:
>> From: Jing Zhang <[email protected]>
>>
>> Date: Wed Apr 7 21:34:48 2010
>>
>> BUG_ON at [line: 2912] could be triggered,
>> if (pa->pa_deleted == 0 && pa->pa_free == 0)
>> as checked at [line: 3111] and [line: 3122].
>
> Please don't use line numbers, as line numbers may not be the same in
> your version and my version. Secondly, please give a high-level
> scenario where this could happen.
>
> - Ted
>

My duty is not over, and I think, more check seems necessary.

- zj