2006-09-09 00:14:25

by Dave Jones

[permalink] [raw]
Subject: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers

This never made it into 2.6.17.12
Without it, this happens..

drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)

Dave


Attachments:
(No filename) (170.00 B)
(No filename) (5.07 kB)
Download all attachments

2006-09-09 00:37:35

by Grant Coady

[permalink] [raw]
Subject: Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers

On Fri, 8 Sep 2006 20:19:25 -0400, Dave Jones <[email protected]> wrote:

>If anyone actually tries to compile this driver the patch below might
>be helpful.

It's a bit late now for -stable, 2.6.17.13 needed ASAP?

Grant.

2006-09-09 01:37:53

by Grant Coady

[permalink] [raw]
Subject: Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers

On Fri, 8 Sep 2006 20:19:25 -0400, Dave Jones <[email protected]> wrote:

>This never made it into 2.6.17.12
>Without it, this happens..
>
>drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
>
> Dave

patching file include/linux/pci_ids.h
Hunk #1 succeeded at 1235 (offset 12 lines).
Hunk #3 succeeded at 1284 (offset 12 lines).

Works here ;)

Grant.

2006-09-09 03:11:06

by Greg KH

[permalink] [raw]
Subject: Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers

On Fri, Sep 08, 2006 at 08:19:25PM -0400, Dave Jones wrote:
> This never made it into 2.6.17.12
> Without it, this happens..
>
> drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)

Doh! Sorry about that, I forgot to do a run with 'make allmodconfig'
this time around, and it shows :(

.13 will be out shortly...

thanks,

greg k-h

2006-09-09 03:45:37

by Dave Jones

[permalink] [raw]
Subject: Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers

On Fri, Sep 08, 2006 at 08:10:20PM -0700, Greg KH wrote:
> On Fri, Sep 08, 2006 at 08:19:25PM -0400, Dave Jones wrote:
> > This never made it into 2.6.17.12
> > Without it, this happens..
> >
> > drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
>
> Doh! Sorry about that, I forgot to do a run with 'make allmodconfig'
> this time around, and it shows :(
>
> .13 will be out shortly...

Might want to throw this in too, which removes a new warning that appeared in 2.6.17.12
warning about implicit declaration of idr_remove

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.17.noarch/drivers/md/dm.c~ 2006-09-08 23:37:08.000000000 -0400
+++ linux-2.6.17.noarch/drivers/md/dm.c 2006-09-08 23:37:16.000000000 -0400
@@ -20,6 +20,7 @@
#include <linux/idr.h>
#include <linux/hdreg.h>
#include <linux/blktrace_api.h>
+#include <linux/idr.h>

static const char *_name = DM_NAME;


2006-09-09 04:15:29

by Greg KH

[permalink] [raw]
Subject: Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers

On Fri, Sep 08, 2006 at 11:46:38PM -0400, Dave Jones wrote:
> On Fri, Sep 08, 2006 at 08:10:20PM -0700, Greg KH wrote:
> > On Fri, Sep 08, 2006 at 08:19:25PM -0400, Dave Jones wrote:
> > > This never made it into 2.6.17.12
> > > Without it, this happens..
> > >
> > > drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
> >
> > Doh! Sorry about that, I forgot to do a run with 'make allmodconfig'
> > this time around, and it shows :(
> >
> > .13 will be out shortly...
>
> Might want to throw this in too, which removes a new warning that appeared in 2.6.17.12
> warning about implicit declaration of idr_remove

That would not have worked, idr_remove wasn't even in the tree :(

I should have fixed it now, thanks.

greg k-h