2024-01-23 15:36:10

by Tudor Ambarus

Subject: [PATCH 06/21] spi: s3c64xx: remove else after return

Else case is not needed after a return, remove it.

Signed-off-by: Tudor Ambarus <[email protected]>
---
drivers/spi/spi-s3c64xx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 9ce56aa792ed..db1e1d6ee732 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -406,12 +406,10 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host,
{
struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host);

- if (sdd->rx_dma.ch && sdd->tx_dma.ch) {
+ if (sdd->rx_dma.ch && sdd->tx_dma.ch)
return xfer->len > FIFO_DEPTH(sdd);
- } else {
- return false;
- }

+ return false;
}

static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd,
--
2.43.0.429.g432eaa2c6b-goog

2024-01-23 19:19:59

by Sam Protsenko

Subject: Re: [PATCH 06/21] spi: s3c64xx: remove else after return

On Tue, Jan 23, 2024 at 9:34 AM Tudor Ambarus <tudor.ambarus@linaroorg> wrote:
>
> Else case is not needed after a return, remove it.
>
> Signed-off-by: Tudor Ambarus <[email protected]>
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> drivers/spi/spi-s3c64xx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 9ce56aa792ed..db1e1d6ee732 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -406,12 +406,10 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host,
> {
> struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host);
>
> - if (sdd->rx_dma.ch && sdd->tx_dma.ch) {
> + if (sdd->rx_dma.ch && sdd->tx_dma.ch)
> return xfer->len > FIFO_DEPTH(sdd);
> - } else {
> - return false;
> - }
>
> + return false;
> }
>
> static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd,
> --
> 2.43.0.429.g432eaa2c6b-goog
>

2024-01-23 22:31:06

by Andi Shyti

Subject: Re: [PATCH 06/21] spi: s3c64xx: remove else after return

Hi Tudor,

On Tue, Jan 23, 2024 at 03:34:05PM +0000, Tudor Ambarus wrote:
> Else case is not needed after a return, remove it.
>
> Signed-off-by: Tudor Ambarus <[email protected]>

Reviewed-by: Andi Shyti <[email protected]>

Thanks,
Andi