2006-12-10 06:48:11

by Paul Collins

[permalink] [raw]
Subject: powerpc: "IRQ probe failed (0x0)" on powerbook

On my PowerBook when booting Linus's tree as of commit af1713e0 I get
something like this:

[blah blah]
ide0: Found Apple UniNorth ATA-6 controller, bus ID 3, irq 0
Probing IDE interface ide0...
hda: HTS541080G9AT00, ATA DISK drive
IRQ probe failed (0x0)
IRQ probe failed (0x0)
IRQ probe failed (0x0)
IRQ probe failed (0x0)

And then of course it fails to mount root. No such problem using a
kernel built from commit 97be852f of December 2nd.

--
Paul Collins
Wellington, New Zealand

Dag vijandelijk luchtschip de huismeester is dood


2006-12-10 08:06:28

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: powerpc: "IRQ probe failed (0x0)" on powerbook

On Sun, 2006-12-10 at 19:45 +1300, Paul Collins wrote:
> On my PowerBook when booting Linus's tree as of commit af1713e0 I get
> something like this:
>
> [blah blah]
> ide0: Found Apple UniNorth ATA-6 controller, bus ID 3, irq 0
> Probing IDE interface ide0...
> hda: HTS541080G9AT00, ATA DISK drive
> IRQ probe failed (0x0)
> IRQ probe failed (0x0)
> IRQ probe failed (0x0)
> IRQ probe failed (0x0)
>
> And then of course it fails to mount root. No such problem using a
> kernel built from commit 97be852f of December 2nd.

I'll investigate tomorrow, looks like irq assignment got broken in a way
or another for that IDE controller.

Ben.


2006-12-10 17:07:30

by Andreas Schwab

[permalink] [raw]
Subject: Re: powerpc: "IRQ probe failed (0x0)" on powerbook

Benjamin Herrenschmidt <[email protected]> writes:

> On Sun, 2006-12-10 at 19:45 +1300, Paul Collins wrote:
>> On my PowerBook when booting Linus's tree as of commit af1713e0 I get
>> something like this:
>>
>> [blah blah]
>> ide0: Found Apple UniNorth ATA-6 controller, bus ID 3, irq 0
>> Probing IDE interface ide0...
>> hda: HTS541080G9AT00, ATA DISK drive
>> IRQ probe failed (0x0)
>> IRQ probe failed (0x0)
>> IRQ probe failed (0x0)
>> IRQ probe failed (0x0)
>>
>> And then of course it fails to mount root. No such problem using a
>> kernel built from commit 97be852f of December 2nd.
>
> I'll investigate tomorrow, looks like irq assignment got broken in a way
> or another for that IDE controller.

Bisection has identified this patch:

commit f90bb153b1493719d18b4529a46ebfe43220ea6c
Author: Benjamin Herrenschmidt <[email protected]>
Date: Sat Nov 11 17:24:51 2006 +1100

[POWERPC] Make pci_read_irq_line the default

Andreas.

--
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."

2006-12-10 19:46:29

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: powerpc: "IRQ probe failed (0x0)" on powerbook


> Bisection has identified this patch:
>
> commit f90bb153b1493719d18b4529a46ebfe43220ea6c
> Author: Benjamin Herrenschmidt <[email protected]>
> Date: Sat Nov 11 17:24:51 2006 +1100
>
> [POWERPC] Make pci_read_irq_line the default

Thanks Andreas ! I was expecting something around that patch indeed, I
suspect something in Apple device-tree is dodgy and breaking the
new generic PCI irq parsing (for example, at first sight, it's a PCI
device with 2 interrupts, which isn't allowed by the PCI spec).

I'll dig a bit more when I get to the office where my crash box is, and
will do a fix.

Ben.


2006-12-11 11:20:23

by Christoph Hellwig

[permalink] [raw]
Subject: Re: powerpc: "IRQ probe failed (0x0)" on powerbook

On Sun, Dec 10, 2006 at 07:45:48PM +1300, Paul Collins wrote:
> On my PowerBook when booting Linus's tree as of commit af1713e0 I get
> something like this:
>
> [blah blah]
> ide0: Found Apple UniNorth ATA-6 controller, bus ID 3, irq 0
> Probing IDE interface ide0...
> hda: HTS541080G9AT00, ATA DISK drive
> IRQ probe failed (0x0)
> IRQ probe failed (0x0)
> IRQ probe failed (0x0)
> IRQ probe failed (0x0)
>
> And then of course it fails to mount root. No such problem using a
> kernel built from commit 97be852f of December 2nd.

Same here, btw - except that I couldn't catch the exact message as
nicely.

2006-12-11 20:30:11

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: powerpc: "IRQ probe failed (0x0)" on powerbook

On Mon, 2006-12-11 at 11:20 +0000, Christoph Hellwig wrote:
> On Sun, Dec 10, 2006 at 07:45:48PM +1300, Paul Collins wrote:
> > On my PowerBook when booting Linus's tree as of commit af1713e0 I get
> > something like this:
> >
> > [blah blah]
> > ide0: Found Apple UniNorth ATA-6 controller, bus ID 3, irq 0
> > Probing IDE interface ide0...
> > hda: HTS541080G9AT00, ATA DISK drive
> > IRQ probe failed (0x0)
> > IRQ probe failed (0x0)
> > IRQ probe failed (0x0)
> > IRQ probe failed (0x0)
> >
> > And then of course it fails to mount root. No such problem using a
> > kernel built from commit 97be852f of December 2nd.
>
> Same here, btw - except that I couldn't catch the exact message as
> nicely.

Yeah, fixed in the patch I sent yesterday [PATCH] powerpc: Fix irq
routing on some PowerMac 32 bit.

Ben



2006-12-11 22:14:51

by Christoph Hellwig

[permalink] [raw]
Subject: Re: powerpc: "IRQ probe failed (0x0)" on powerbook

On Tue, Dec 12, 2006 at 07:28:23AM +1100, Benjamin Herrenschmidt wrote:
> > Same here, btw - except that I couldn't catch the exact message as
> > nicely.
>
> Yeah, fixed in the patch I sent yesterday [PATCH] powerpc: Fix irq
> routing on some PowerMac 32 bit.

Confirmed, everything is fine with that patch.