2010-04-28 07:40:39

by Alex Riesen

[permalink] [raw]
Subject: Re: [patch 1/1] sunrpc: use formatting of module name in SUNRPC

On Tue, Apr 27, 2010 at 23:15, <[email protected]> wrote:
> From: Alex Riesen <[email protected]>
>
> gcc-4.3.3 produces the warning:
>  "format not a string literal and no format arguments"
>
> Signed-off-by: Alex Riesen <[email protected]>
> Cc: Trond Myklebust <[email protected]>
> Cc: Chuck Lever <[email protected]>
> Cc: David S. Miller <[email protected]>
> Acked-by: Tom Talpey <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
> ---
>
>  net/sunrpc/xprt.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>

This is one tough little patch... 2 years and counting...


2010-04-28 14:42:15

by Andrew Morton

[permalink] [raw]
Subject: Re: [patch 1/1] sunrpc: use formatting of module name in SUNRPC

On Wed, 28 Apr 2010 09:40:36 +0200 Alex Riesen <[email protected]> wrote:

> On Tue, Apr 27, 2010 at 23:15, <[email protected]> wrote:
> > From: Alex Riesen <[email protected]>
> >
> > gcc-4.3.3 produces the warning:
> > __"format not a string literal and no format arguments"
> >
> > Signed-off-by: Alex Riesen <[email protected]>
> > Cc: Trond Myklebust <[email protected]>
> > Cc: Chuck Lever <[email protected]>
> > Cc: David S. Miller <[email protected]>
> > Acked-by: Tom Talpey <[email protected]>
> > Signed-off-by: Andrew Morton <[email protected]>
> > ---
> >
> > __net/sunrpc/xprt.c | __ __5 +----
> > __1 file changed, 1 insertion(+), 4 deletions(-)
> >
>
> This is one tough little patch... 2 years and counting...

heh. I've only had it since June '09.

I'll merge it into 2.6.35-rc1.

2010-04-28 19:49:13

by Alex Riesen

[permalink] [raw]
Subject: Re: [patch 1/1] sunrpc: use formatting of module name in SUNRPC

On Wed, Apr 28, 2010 at 13:39, Andrew Morton <[email protected]> wrote:
> On Wed, 28 Apr 2010 09:40:36 +0200 Alex Riesen <[email protected]> wrote:
>> > __net/sunrpc/xprt.c | __ __5 +----
>> > __1 file changed, 1 insertion(+), 4 deletions(-)
>> >
>>
>> This is one tough little patch... 2 years and counting...
>
> heh.  I've only had it since June '09.
>
> I'll merge it into 2.6.35-rc1.
>

That's because I was overly pessimistic. gcc-4.3.3 only exists since
24 Jan, 2009.
I just have the change (and other request_module name formatting patches)
in my trees already for quite some time...