LinuxLists.cc - 2.6.29-rc8-git5: Reported regressions from 2.6.28

2009-03-21 19:08:29

Subject: 2.6.29-rc8-git5: Reported regressions from 2.6.28

This message contains a list of some regressions from 2.6.28, for which there
are no fixes in the mainline I know of. If any of them have been fixed already,
please let me know.

If you know of any other unresolved regressions from 2.6.28, please let me know
either and I'll add them to the list. Also, please let me know if any of the
entries below are invalid.

Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.

Listed regressions statistics:

Date Total Pending Unresolved
----------------------------------------
2009-03-21 128 29 26
2009-03-14 124 36 32
2009-03-03 108 33 28
2009-02-24 95 32 24
2009-02-14 85 33 27
2009-02-08 82 45 36
2009-02-04 66 51 39
2009-01-20 38 35 27
2009-01-11 13 13 10

Unresolved regressions
----------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12910
Subject : Wierd iteractions with CPUFREQ
Submitter : Dmitry Torokhov <[email protected]>
Date : 2009-03-19 5:57 (3 days old)
References : http://marc.info/?l=linux-kernel&m=123744265002098&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12909
Subject : boot/kernel init duration regression from 2.6.28
Submitter : CaT <[email protected]>
Date : 2009-03-16 10:25 (6 days old)
References : http://marc.info/?l=linux-kernel&m=123720083515950&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12908
Subject : acpi_ex_extract_from_field -- div by zero
Submitter : Jiri Slaby <[email protected]>
Date : 2009-03-15 10:47 (7 days old)
References : http://marc.info/?l=linux-kernel&m=123711408225013&w=4
Handled-By : Lin Ming <[email protected]>

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12872
Subject : pwc mmap always fails with EAGAIN
Submitter : Markus <[email protected]>
Date : 2009-03-14 16:42 (8 days old)
References : http://marc.info/?l=linux-kernel&m=123704902201378&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12871
Subject : usb bluetooth crashes system
Submitter : Pavel Machek <[email protected]>
Date : 2009-03-10 11:23 (12 days old)
References : http://marc.info/?l=linux-kernel&m=123668450400940&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12867
Subject : 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board
Submitter : Mikael Pettersson <[email protected]>
Date : 2009-03-09 20:29 (13 days old)
References : http://marc.info/?l=linux-kernel&m=123663065403760&w=4
Handled-By : Francois Romieu <[email protected]>

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12861
Subject : Xorg fails to start "Failed to allocate space for kernel memory manager"
Submitter : Emil Karlson <[email protected]>
Date : 2009-03-12 12:06 (10 days old)

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12856
Subject : Thinkpad freezes with X.org and acpi=rsdt
Submitter : Maciej Piechotka <[email protected]>
Date : 2009-03-11 16:46 (11 days old)

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12846
Subject : Regression issue with kernel 2.6.29-rc6-git1: high power consumption during sleep
Submitter : Raymond Wooninck <[email protected]>
Date : 2009-03-09 08:18 (13 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1fb25cb8b83e85f5bf1a4adb3c9a254c4ce92405

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12836
Subject : 2.6.29-rc breaks STD using Intel 945
Submitter : Rolf Eike Beer <[email protected]>
Date : 2009-03-04 19:20 (18 days old)
References : http://marc.info/?l=linux-kernel&m=123619451406192&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12809
Subject : iozone regression with 2.6.29-rc6
Submitter : Lin Ming <[email protected]>
Date : 2009-02-27 9:13 (23 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cf6e7d83bf334cc5916137862c920a97aabc018
References : http://marc.info/?l=linux-kernel&m=123572630504360&w=4
http://lkml.org/lkml/2009/3/14/265
Handled-By : Wu Fengguang <[email protected]>

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12808
Subject : Suspend regression with 2.6.29-rc
Submitter : Tino Keitel <[email protected]>
Date : 2009-02-24 19:08 (26 days old)
References : http://marc.info/?l=linux-kernel&m=123550257312112&w=4
Handled-By : Rafael J. Wysocki <[email protected]>

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12800
Subject : x86 PAT invalid vm_insert_pfn assumptions
Submitter : Thomas Hellstrom <[email protected]>
Date : 2009-03-02 01:40 (20 days old)

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12792
Subject : 2.6.29-rc6-git4 boot failure
Submitter : Sachin P. Sant <[email protected]>
Date : 2009-02-27 23:19 (23 days old)
References : http://ozlabs.org/pipermail/linuxppc-dev/2009-February/068771.html

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12778
Subject : suspend regression from 29rc5 to 29rc6
Submitter : yury <[email protected]>
Date : 2009-02-25 09:25 (25 days old)

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12771
Subject : Oops in i915_gem_flush
Submitter : Kalev Lember <[email protected]>
Date : 2009-02-24 08:35 (26 days old)

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12765
Subject : i915 VT switch with AIGLX causes X lock up
Submitter : Sitsofe Wheeler <[email protected]>
Date : 2009-02-21 15:38 (29 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=14d200c5e5bd19219d930bbb9a5a22758c8f5bec
References : http://marc.info/?l=linux-kernel&m=123523074304955&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12763
Subject : Different cpu MHz values for processor0 and processor1
Submitter : Matthew A. Bockol <[email protected]>
Date : 2009-02-21 5:42 (29 days old)
References : http://marc.info/?l=linux-kernel&m=123519687807246&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12705
Subject : X200: Brightness broken since 2.6.29-rc4-58-g4c098bc
Submitter : Nico Schottelius <[email protected]>
Date : 2009-02-13 9:33 (37 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e806b4957412bf472d826bd8cc571da041248799
References : http://marc.info/?l=linux-kernel&m=123451768406825&w=4
http://marc.info/?l=linux-kernel&m=123479975503827&w=2
Handled-By : Len Brown <[email protected]>

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12681
Subject : s2ram: fails to wake up on Acer Extensa 4220 (SMP disabled)
Submitter : Orivej Desh <[email protected]>
Date : 2009-02-09 13:01 (41 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cfe62c8010ac56e1bd3827e30386a87cc2f3594

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12670
Subject : BUG: unable to handle kernel paging request at pin_to_kill+0x21
Submitter : Alessandro Bono <[email protected]>
Date : 2009-02-08 11:04 (42 days old)
References : http://marc.info/?l=linux-kernel&m=123409113223833&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12668
Subject : USB flash disk surprise disconnect
Submitter : Vegard Nossum <[email protected]>
Date : 2009-02-08 10:21 (42 days old)
References : http://marc.info/?l=linux-kernel&m=123408851821292&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12574
Subject : possible circular locking dependency detected
Submitter : Michael S. Tsirkin <[email protected]>
Date : 2009-01-29 11:35 (52 days old)
References : http://lkml.org/lkml/2009/2/9/205

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12499
Subject : Problem with using bluetooth adaper connected to usb port
Submitter : Maciej Rutecki <[email protected]>
Date : 2009-01-13 18:34 (68 days old)
References : http://marc.info/?l=linux-kernel&m=123187185426236&w=4

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12490
Subject : ath5k related kernel panic in 2.6.29-rc1
Submitter : Sergey S. Kostyliov <[email protected]>
Date : 2009-01-12 7:38 (69 days old)
References : http://marc.info/?l=linux-kernel&m=123174591509586&w=4
Handled-By : Bob Copeland <[email protected]>

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12419
Subject : possible circular locking dependency on i915 dma
Submitter : Wang Chen <[email protected]>
Date : 2009-01-08 14:11 (73 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=546b0974c39657017407c86fe79811100b60700d
References : http://marc.info/?l=linux-kernel&m=123142399720125&w=4

Regressions with patches
------------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12870
Subject : 2.6.29-rc "TKIP: replay detected" regression
Submitter : Hugh Dickins <[email protected]>
Date : 2009-03-11 12:07 (11 days old)
References : http://marc.info/?l=linux-kernel&m=123677337219148&w=4
Handled-By : John W. Linville <[email protected]>
Patch : http://marc.info/?l=linux-wireless&m=123678463704691&w=2

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12671
Subject : uvc_status_cleanup(): undefined reference to `input_unregister_device'
Submitter : Ingo Molnar <[email protected]>
Date : 2009-02-08 14:58 (42 days old)
References : http://marc.info/?l=linux-kernel&m=123410529909318&w=4
Handled-By : Randy Dunlap <[email protected]>
Patch : http://lkml.org/lkml/2009/2/15/172

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12667
Subject : Badness at kernel/time/timekeeping.c:98 in pmud (timekeeping_suspended)
Submitter : Paul Collins <[email protected]>
Date : 2009-01-21 7:15 (60 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1c5745aa380efb6417b5681104b007c8612fb496
References : http://marc.info/?l=linux-kernel&m=123252215315106&w=4
Handled-By : Benjamin Herrenschmidt <[email protected]>
Patch : http://lkml.org/lkml/2009/2/16/78

For details, please visit the bug entries and follow the links given in
references.

As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.28,
unresolved as well as resolved, at:

http://bugzilla.kernel.org/show_bug.cgi?id=12398

Please let me know if there are any Bugzilla entries that should be added to
the list in there.

Thanks,
Rafael

2009-03-21 19:08:44

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12419] possible circular locking dependency on i915 dma

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12419
Subject : possible circular locking dependency on i915 dma
Submitter : Wang Chen <[email protected]>
Date : 2009-01-08 14:11 (73 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=546b0974c39657017407c86fe79811100b60700d
References : http://marc.info/?l=linux-kernel&m=123142399720125&w=4

2009-03-21 19:18:40

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12574] possible circular locking dependency detected

2009-03-21 19:19:05

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12667] Badness at kernel/time/timekeeping.c:98 in pmud (timekeeping_suspended)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12667
Subject : Badness at kernel/time/timekeeping.c:98 in pmud (timekeeping_suspended)
Submitter : Paul Collins <[email protected]>
Date : 2009-01-21 7:15 (60 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1c5745aa380efb6417b5681104b007c8612fb496
References : http://marc.info/?l=linux-kernel&m=123252215315106&w=4
Handled-By : Benjamin Herrenschmidt <[email protected]>
Patch : http://lkml.org/lkml/2009/2/16/78

2009-03-21 19:19:29

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12499] Problem with using bluetooth adaper connected to usb port

2009-03-21 19:19:49

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12668] USB flash disk surprise disconnect

2009-03-21 19:20:45

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12671] uvc_status_cleanup(): undefined reference to `input_unregister_device'

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12671
Subject : uvc_status_cleanup(): undefined reference to `input_unregister_device'
Submitter : Ingo Molnar <[email protected]>
Date : 2009-02-08 14:58 (42 days old)
References : http://marc.info/?l=linux-kernel&m=123410529909318&w=4
Handled-By : Randy Dunlap <[email protected]>
Patch : http://lkml.org/lkml/2009/2/15/172

2009-03-21 19:20:18

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12490
Subject : ath5k related kernel panic in 2.6.29-rc1
Submitter : Sergey S. Kostyliov <[email protected]>
Date : 2009-01-12 7:38 (69 days old)
References : http://marc.info/?l=linux-kernel&m=123174591509586&w=4
Handled-By : Bob Copeland <[email protected]>

2009-03-21 19:21:03

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12670] BUG: unable to handle kernel paging request at pin_to_kill+0x21

2009-03-21 19:21:27

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12763] Different cpu MHz values for processor0 and processor1

2009-03-21 19:21:42

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12705] X200: Brightness broken since 2.6.29-rc4-58-g4c098bc

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12705
Subject : X200: Brightness broken since 2.6.29-rc4-58-g4c098bc
Submitter : Nico Schottelius <[email protected]>
Date : 2009-02-13 9:33 (37 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e806b4957412bf472d826bd8cc571da041248799
References : http://marc.info/?l=linux-kernel&m=123451768406825&w=4
http://marc.info/?l=linux-kernel&m=123479975503827&w=2
Handled-By : Len Brown <[email protected]>

2009-03-21 19:22:00

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12778] suspend regression from 29rc5 to 29rc6

2009-03-21 19:22:40

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12792] 2.6.29-rc6-git4 boot failure

2009-03-21 19:22:22

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12681] s2ram: fails to wake up on Acer Extensa 4220 (SMP disabled)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12681
Subject : s2ram: fails to wake up on Acer Extensa 4220 (SMP disabled)
Submitter : Orivej Desh <[email protected]>
Date : 2009-02-09 13:01 (41 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cfe62c8010ac56e1bd3827e30386a87cc2f3594

2009-03-21 19:22:57

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12771] Oops in i915_gem_flush

2009-03-21 19:23:24

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12765] i915 VT switch with AIGLX causes X lock up

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12765
Subject : i915 VT switch with AIGLX causes X lock up
Submitter : Sitsofe Wheeler <[email protected]>
Date : 2009-02-21 15:38 (29 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=14d200c5e5bd19219d930bbb9a5a22758c8f5bec
References : http://marc.info/?l=linux-kernel&m=123523074304955&w=4

2009-03-21 19:23:41

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12800] x86 PAT invalid vm_insert_pfn assumptions

2009-03-21 19:23:59

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12808] Suspend regression with 2.6.29-rc

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12808
Subject : Suspend regression with 2.6.29-rc
Submitter : Tino Keitel <[email protected]>
Date : 2009-02-24 19:08 (26 days old)
References : http://marc.info/?l=linux-kernel&m=123550257312112&w=4
Handled-By : Rafael J. Wysocki <[email protected]>

2009-03-21 19:24:23

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12809] iozone regression with 2.6.29-rc6

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12809
Subject : iozone regression with 2.6.29-rc6
Submitter : Lin Ming <[email protected]>
Date : 2009-02-27 9:13 (23 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cf6e7d83bf334cc5916137862c920a97aabc018
References : http://marc.info/?l=linux-kernel&m=123572630504360&w=4
http://lkml.org/lkml/2009/3/14/265
Handled-By : Wu Fengguang <[email protected]>

2009-03-21 19:24:40

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12836] 2.6.29-rc breaks STD using Intel 945

2009-03-21 19:24:57

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12872] pwc mmap always fails with EAGAIN

2009-03-21 19:25:25

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12861] Xorg fails to start "Failed to allocate space for kernel memory manager"

2009-03-21 19:25:45

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12856] Thinkpad freezes with X.org and acpi=rsdt

2009-03-21 19:25:58

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12846] Regression issue with kernel 2.6.29-rc6-git1: high power consumption during sleep

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12846
Subject : Regression issue with kernel 2.6.29-rc6-git1: high power consumption during sleep
Submitter : Raymond Wooninck <[email protected]>
Date : 2009-03-09 08:18 (13 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1fb25cb8b83e85f5bf1a4adb3c9a254c4ce92405

2009-03-21 19:26:28

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12870] 2.6.29-rc "TKIP: replay detected" regression

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12870
Subject : 2.6.29-rc "TKIP: replay detected" regression
Submitter : Hugh Dickins <[email protected]>
Date : 2009-03-11 12:07 (11 days old)
References : http://marc.info/?l=linux-kernel&m=123677337219148&w=4
Handled-By : John W. Linville <[email protected]>
Patch : http://marc.info/?l=linux-wireless&m=123678463704691&w=2

2009-03-21 19:26:45

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12871] usb bluetooth crashes system

2009-03-21 19:27:25

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12908] acpi_ex_extract_from_field -- div by zero

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12908
Subject : acpi_ex_extract_from_field -- div by zero
Submitter : Jiri Slaby <[email protected]>
Date : 2009-03-15 10:47 (7 days old)
References : http://marc.info/?l=linux-kernel&m=123711408225013&w=4
Handled-By : Lin Ming <[email protected]>

2009-03-21 19:27:04

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12867] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12867
Subject : 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board
Submitter : Mikael Pettersson <[email protected]>
Date : 2009-03-09 20:29 (13 days old)
References : http://marc.info/?l=linux-kernel&m=123663065403760&w=4
Handled-By : Francois Romieu <[email protected]>

2009-03-21 19:27:42

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12909] boot/kernel init duration regression from 2.6.28

2009-03-21 19:27:58

by Rafael J. Wysocki

[permalink] [raw]

Subject: [Bug #12910] Wierd iteractions with CPUFREQ

2009-03-21 19:52:58

by Hugh Dickins

[permalink] [raw]

Subject: Re: [Bug #12870] 2.6.29-rc "TKIP: replay detected" regression

On Sat, 21 Mar 2009, Rafael J. Wysocki wrote:
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12870
> Subject : 2.6.29-rc "TKIP: replay detected" regression
> Submitter : Hugh Dickins <[email protected]>
> Date : 2009-03-11 12:07 (11 days old)
> References : http://marc.info/?l=linux-kernel&m=123677337219148&w=4
> Handled-By : John W. Linville <[email protected]>
> Patch : http://marc.info/?l=linux-wireless&m=123678463704691&w=2

Yes, it still needs to be listed: I don't know why,
but John's patch has not yet appeared in Linus's tree.

Hugh

2009-03-21 20:08:25

by Ingo Molnar

[permalink] [raw]

Subject: Re: 2.6.29-rc8-git5: Reported regressions from 2.6.28

* Rafael J. Wysocki <[email protected]> wrote:

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12809
> Subject : iozone regression with 2.6.29-rc6
> Submitter : Lin Ming <[email protected]>
> Date : 2009-02-27 9:13 (23 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cf6e7d83bf334cc5916137862c920a97aabc018
> References : http://marc.info/?l=linux-kernel&m=123572630504360&w=4
> http://lkml.org/lkml/2009/3/14/265
> Handled-By : Wu Fengguang <[email protected]>

I think this was tracked back to the effective halving of
dirty_ratio by 1cf6e7d83 ("mm: task dirty accounting fix") and
doubling the ratio fixed the iozone regression.

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12800
> Subject : x86 PAT invalid vm_insert_pfn assumptions
> Submitter : Thomas Hellstrom <[email protected]>
> Date : 2009-03-02 01:40 (20 days old)

fix queued up for .30:

895791d: VM, x86, PAT: add a new vm flag to track full pfnmap at mmap
4bb9c5c: VM, x86, PAT: Change is_linear_pfn_mapping to not use vm_pgoff

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12763
> Subject : Different cpu MHz values for processor0 and processor1
> Submitter : Matthew A. Bockol <[email protected]>
> Date : 2009-02-21 5:42 (29 days old)
> References : http://marc.info/?l=linux-kernel&m=123519687807246&w=4

first-bad-commit:

d96f94c: ACPI: Enable bit 11 in _PDC to advertise hw coord

Ingo

2009-03-22 10:06:54

by Pavel Machek

[permalink] [raw]

Subject: Re: [Bug #12871] usb bluetooth crashes system

On Sat 2009-03-21 17:39:07, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>

In the meantime I verified that btusb.c from 2.6.28 does not have the
problem, and started to do kind of manual-bisect.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2009-03-22 12:37:51

by Markus

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me
know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12872
> Subject : pwc mmap always fails with EAGAIN
> Submitter : Markus <[email protected]>
> Date : 2009-03-14 16:42 (8 days old)
> References : http://marc.info/?l=linux-kernel&m=123704902201378&w=4

Still valid for 2.6.29-rc8-git5.

Markus

2009-03-22 13:52:00

by Mikael Pettersson

[permalink] [raw]

Subject: Re: [Bug #12867] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

Rafael J. Wysocki wrote:
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=3D12867
> Subject : 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board
> Submitter : Mikael Pettersson <[email protected]>
> Date : 2009-03-09 20:29 (13 days old)
> References : http://marc.info/?l=3Dlinux-kernel&m=3D123663065403760&w=3D4
> Handled-By : Francois Romieu <[email protected]>

Fixed in Linus' tree by ea8dbdd17099a9a5864ebd4c87e01e657b19c7ab.

2009-03-22 14:28:21

by Alan

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

On Sun, 22 Mar 2009 13:37:35 +0100
Markus <[email protected]> wrote:

> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me
> know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12872
> > Subject : pwc mmap always fails with EAGAIN
> > Submitter : Markus <[email protected]>
> > Date : 2009-03-14 16:42 (8 days old)
> > References : http://marc.info/?l=linux-kernel&m=123704902201378&w=4
>
> Still valid for 2.6.29-rc8-git5.

And not really likely to change until someone with a pwc camera adds lots
of printks to the code to work out why this happens.

2009-03-22 14:45:51

by Ingo Molnar

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

* Alan Cox <[email protected]> wrote:

> On Sun, 22 Mar 2009 13:37:35 +0100
> Markus <[email protected]> wrote:
>
> > > This message has been generated automatically as a part of a report
> > > of recent regressions.
> > >
> > > The following bug entry is on the current list of known regressions
> > > from 2.6.28. Please verify if it still should be listed and let me
> > know
> > > (either way).
> > >
> > >
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12872
> > > Subject : pwc mmap always fails with EAGAIN
> > > Submitter : Markus <[email protected]>
> > > Date : 2009-03-14 16:42 (8 days old)
> > > References : http://marc.info/?l=linux-kernel&m=123704902201378&w=4
> >
> > Still valid for 2.6.29-rc8-git5.
>
> And not really likely to change until someone with a pwc camera adds lots
> of printks to the code to work out why this happens.

Or does a bisection to figure out the bad commit, because the report
says that 2.6.28 worked.

The 'howto bisect' portion of:

http://www.kernel.org/doc/local/git-quick.html

Ingo

2009-03-22 19:58:33

by Markus

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

> > > Still valid for 2.6.29-rc8-git5.
> >
> > And not really likely to change until someone with a pwc camera adds
lots
> > of printks to the code to work out why this happens.
>
> Or does a bisection to figure out the bad commit, because the report
> says that 2.6.28 worked.
>
> The 'howto bisect' portion of:
>
> http://www.kernel.org/doc/local/git-quick.html

Well I did a bisect:
be03d9e8022030c16abf534e33e185bfc3d40eef is first bad commit
commit be03d9e8022030c16abf534e33e185bfc3d40eef
Author: Suresh Siddha <[email protected]>
Date: Wed Feb 11 11:20:23 2009 -0800

x86, pat: fix warn_on_once() while mapping 0-1MB range with /dev/mem

Jeff Mahoney reported:

> With Suse's hwinfo tool, on -tip:
> WARNING: at arch/x86/mm/pat.c:637 reserve_pfn_range+0x5b/0x26d()

reserve_pfn_range() is not tracking the memory range below 1MB
as non-RAM and as such is inconsistent with similar checks in
reserve_memtype() and free_memtype()

Rename the pagerange_is_ram() to pat_pagerange_is_ram() and add the
"track legacy 1MB region as non RAM" condition.

And also, fix reserve_pfn_range() to return -EINVAL, when the pfn
range is RAM. This is to be consistent with this API design.

Reported-and-tested-by: Jeff Mahoney <[email protected]>
Signed-off-by: Suresh Siddha <[email protected]>
Signed-off-by: Venkatesh Pallipadi <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>

:040000 040000 feb3bf21d762e885284cb1bedb5d2c6c0d16811b
b4c2143775386ce15dd49b6749c1f7913d8beb00 M arch

So I ran "git bisect reset ; git revert
be03d9e8022030c16abf534e33e185bfc3d40eef" and rebuild. That worked!

I dont know if this is valid to do, but its working fine.
Its an amd64 system with CONFIG_X86_PAT=y.

Need some feedback ;)

Markus

2009-03-22 20:05:53

by Ingo Molnar

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

* Markus <[email protected]> wrote:

> > > > Still valid for 2.6.29-rc8-git5.
> > >
> > > And not really likely to change until someone with a pwc camera adds
> lots
> > > of printks to the code to work out why this happens.
> >
> > Or does a bisection to figure out the bad commit, because the report
> > says that 2.6.28 worked.
> >
> > The 'howto bisect' portion of:
> >
> > http://www.kernel.org/doc/local/git-quick.html
>
>
> Well I did a bisect:
> be03d9e8022030c16abf534e33e185bfc3d40eef is first bad commit
> commit be03d9e8022030c16abf534e33e185bfc3d40eef
> Author: Suresh Siddha <[email protected]>
> Date: Wed Feb 11 11:20:23 2009 -0800
>
> x86, pat: fix warn_on_once() while mapping 0-1MB range with /dev/mem
>
> Jeff Mahoney reported:
>
> > With Suse's hwinfo tool, on -tip:
> > WARNING: at arch/x86/mm/pat.c:637 reserve_pfn_range+0x5b/0x26d()
>
> reserve_pfn_range() is not tracking the memory range below 1MB
> as non-RAM and as such is inconsistent with similar checks in
> reserve_memtype() and free_memtype()
>
> Rename the pagerange_is_ram() to pat_pagerange_is_ram() and add the
> "track legacy 1MB region as non RAM" condition.
>
> And also, fix reserve_pfn_range() to return -EINVAL, when the pfn
> range is RAM. This is to be consistent with this API design.
>
> Reported-and-tested-by: Jeff Mahoney <[email protected]>
> Signed-off-by: Suresh Siddha <[email protected]>
> Signed-off-by: Venkatesh Pallipadi <[email protected]>
> Signed-off-by: Ingo Molnar <[email protected]>
>
> :040000 040000 feb3bf21d762e885284cb1bedb5d2c6c0d16811b
> b4c2143775386ce15dd49b6749c1f7913d8beb00 M arch
>
> So I ran "git bisect reset ; git revert
> be03d9e8022030c16abf534e33e185bfc3d40eef" and rebuild. That worked!
>
> I dont know if this is valid to do, but its working fine.
> Its an amd64 system with CONFIG_X86_PAT=y.
>
> Need some feedback ;)

First thing to check would be whether the latest round of PAT fixes
(not yet upstream) fix the problem:

http://people.redhat.com/mingo/tip.git/README

Suresh, any ideas?

Ingo

2009-03-22 21:50:36

by Benjamin Herrenschmidt

[permalink] [raw]

Subject: Re: [Bug #12792] 2.6.29-rc6-git4 boot failure

On Sat, 2009-03-21 at 17:39 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).

Sachin, did you find anything about this one ?

Cheers,
Ben.
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12792
> Subject : 2.6.29-rc6-git4 boot failure
> Submitter : Sachin P. Sant <[email protected]>
> Date : 2009-02-27 23:19 (23 days old)
> References : http://ozlabs.org/pipermail/linuxppc-dev/2009-February/068771.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2009-03-23 00:58:32

by Fengguang Wu

[permalink] [raw]

Subject: Re: 2.6.29-rc8-git5: Reported regressions from 2.6.28

On Sun, Mar 22, 2009 at 04:05:34AM +0800, Ingo Molnar wrote:
>
> * Rafael J. Wysocki <[email protected]> wrote:
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12809
> > Subject : iozone regression with 2.6.29-rc6
> > Submitter : Lin Ming <[email protected]>
> > Date : 2009-02-27 9:13 (23 days old)
> > First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1cf6e7d83bf334cc5916137862c920a97aabc018
> > References : http://marc.info/?l=linux-kernel&m=123572630504360&w=4
> > http://lkml.org/lkml/2009/3/14/265
> > Handled-By : Wu Fengguang <[email protected]>
>
> I think this was tracked back to the effective halving of
> dirty_ratio by 1cf6e7d83 ("mm: task dirty accounting fix") and
> doubling the ratio fixed the iozone regression.

Yes, exactly. The patch for fixing this regression is trivial.

However it may be better to revert 1cf6e7d83 for 2.6.29,
and merge 1cf6e7d83 together with this patch for 2.6.30-rc1.
This allows a larger window for testing out the possible impacts
on other workloads.

Thanks,
Fengguang
---
writeback: double the dirty thresholds

Enlarge default dirty ratios from 5/10 to 10/20.
This fixes [Bug #12809] iozone regression with 2.6.29-rc6.

The iozone benchmarks are performed on a 1200M file, with 8GB ram.

iozone -i 0 -i 1 -i 2 -i 3 -i 4 -r 4k -s 64k -s 512m -s 1200m -b tmp.xls
iozone -B -r 4k -s 64k -s 512m -s 1200m -b tmp.xls

The performance regression is triggered by commit 1cf6e7d83bf3(mm: task
dirty accounting fix), which makes more correct/thorough dirty accounting.

The default 5/10 dirty ratios were picked (a) with the old dirty
logic and (b) largely at random and (c) designed to be aggressive. In
particular, that (a) means that having fixed some of the dirty accounting,
maybe the real bug is now that it was always too aggressive, just hidden
by an accounting issue.

The enlarged 10/20 dirty ratios are just about enough to fix the regression.

Cc: Nick Piggin <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Linus Torvalds <[email protected]>
Reported-by: "Lin, Ming M" <[email protected]>
Tested-by: "Lin, Ming M" <[email protected]>
Signed-off-by: Wu Fengguang <[email protected]>
---
mm/page-writeback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- mm.orig/mm/page-writeback.c
+++ mm/mm/page-writeback.c
@@ -66,7 +66,7 @@ static inline long sync_writeback_pages(
/*
* Start background writeback (via pdflush) at this percentage
*/
-int dirty_background_ratio = 5;
+int dirty_background_ratio = 10;

/*
* dirty_background_bytes starts at 0 (disabled) so that it is a function of
@@ -83,7 +83,7 @@ int vm_highmem_is_dirtyable;
/*
* The generator of dirty data starts writeback at this percentage
*/
-int vm_dirty_ratio = 10;
+int vm_dirty_ratio = 20;

/*
* vm_dirty_bytes starts at 0 (disabled) so that it is a function of

2009-03-23 05:05:08

by Sachin Sant

[permalink] [raw]

Subject: Re: [Bug #12792] 2.6.29-rc6-git4 boot failure

Benjamin Herrenschmidt wrote:
> On Sat, 2009-03-21 at 17:39 +0100, Rafael J. Wysocki wrote:
>
>> This message has been generated automatically as a part of a report
>> of recent regressions.
>>
>> The following bug entry is on the current list of known regressions
>> from 2.6.28. Please verify if it still should be listed and let me know
>> (either way).
>>
>
> Sachin, did you find anything about this one ?
>
Hi Ben,

I narrowed it down to 2.6.28-git2(Boots) while 2.6.28-git4(fails to boot).
I could not boot test 2.6.28-git3 as i ran into kernel compilation issues.

Here is the error message i got when i tried compiling 2.6.28-git3.

LD vmlinux.o
ld: dynreloc miscount for kernel/built-in.o, section .opd
ld: can not edit opd Bad value

I think the above one was some tool chain related issue.

I don't know how to git bisect using these two releases (2.6.28-git2/2.6.28-git4).
I guess that is not possible since there are no commit tags for these releases.
But i could be wrong.

Is there anything else that i could try out to find a solution for this ?
The machine in question is a Power Mac G5 running Ubuntu Hardy with a
PPC970, altivec supported CPU(2).

For the record i can still recreate this issue with 2.6.29-rc8-git6.

Thanks
-Sachin

--

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------

2009-03-23 06:05:42

by Benjamin Herrenschmidt

[permalink] [raw]

Subject: Re: [Bug #12792] 2.6.29-rc6-git4 boot failure

> I narrowed it down to 2.6.28-git2(Boots) while 2.6.28-git4(fails to boot).
> I could not boot test 2.6.28-git3 as i ran into kernel compilation issues.
>
> Here is the error message i got when i tried compiling 2.6.28-git3.
>
> LD vmlinux.o
> ld: dynreloc miscount for kernel/built-in.o, section .opd
> ld: can not edit opd Bad value
>
> I think the above one was some tool chain related issue.
>
> I don't know how to git bisect using these two releases (2.6.28-git2/2.6.28-git4).
> I guess that is not possible since there are no commit tags for these releases.
> But i could be wrong.
>
> Is there anything else that i could try out to find a solution for this ?
> The machine in question is a Power Mac G5 running Ubuntu Hardy with a
> PPC970, altivec supported CPU(2).
>
> For the record i can still recreate this issue with 2.6.29-rc8-git6.

Strange I have such a powermac here and haven't seen that problem... let
me dig a bit.

Cheers,
Ben.

2009-03-23 10:49:33

by Alan

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

> > Rename the pagerange_is_ram() to pat_pagerange_is_ram() and add the
> > "track legacy 1MB region as non RAM" condition.

But the lowest 640K are most definitely RAM.

2009-03-23 14:11:23

by Arjan van de Ven

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

On Mon, 23 Mar 2009 10:49:45 +0000
Alan Cox <[email protected]> wrote:

> > > Rename the pagerange_is_ram() to pat_pagerange_is_ram() and
> > > add the "track legacy 1MB region as non RAM" condition.
>
> But the lowest 640K are most definitely RAM.

not all of it ;)

"ram" is defined as "the kernel memory allocator knows about it and
would hand it out" in this context; BIOS owned areas are not "ram" in
this context.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org

2009-03-23 16:33:25

by Linus Torvalds

[permalink] [raw]

Subject: Re: 2.6.29-rc8-git5: Reported regressions from 2.6.28

On Mon, 23 Mar 2009, Wu Fengguang wrote:
> >
> > I think this was tracked back to the effective halving of
> > dirty_ratio by 1cf6e7d83 ("mm: task dirty accounting fix") and
> > doubling the ratio fixed the iozone regression.
>
> Yes, exactly. The patch for fixing this regression is trivial.

I was planning on applying that patch only after 2.6.29 is out, and then
if there are no surprising side effects and nobody complains, we'd then
back-port it into stable.

Linus

2009-04-02 15:49:35

by Markus

[permalink] [raw]

Subject: Re: [Bug #12872] pwc mmap always fails with EAGAIN

> First thing to check would be whether the latest round of PAT fixes
> (not yet upstream) fix the problem:

I checked 2.6.29 (the vanilla release) it still has this regression.

I also checked your "tip"-version and it works! (Built the kernel on
march the 25th. But got no time to test it... up to now...)

Markus

2009-04-06 23:03:43

by Hugh Dickins

[permalink] [raw]

Subject: Re: [Bug #12870] 2.6.29-rc "TKIP: replay detected" regression

On Mon, 6 Apr 2009, Rafael J. Wysocki wrote:
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12870
> Subject : 2.6.29-rc "TKIP: replay detected" regression
> Submitter : Hugh Dickins <[email protected]>
> Date : 2009-03-11 12:07 (27 days old)
> References : http://marc.info/?l=linux-kernel&m=123677337219148&w=4
> Handled-By : "John W. Linville" <[email protected]>
> Patch : http://marc.info/?l=linux-wireless&m=123678463704691&w=2

John's fix went into 2.6.29 final: please remove this regression now.

Hugh

2009-04-07 02:41:27

by Bob Copeland

[permalink] [raw]

Subject: Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

On Mon, Apr 06, 2009 at 08:55:05PM +0200, Rafael J. Wysocki wrote:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12490
> Subject : ath5k related kernel panic in 2.6.29-rc1
> Submitter : "Sergey S. Kostyliov" <[email protected]>
> Date : 2009-01-12 7:38 (85 days old)
> References : http://marc.info/?l=linux-kernel&m=123174591509586&w=4
> Handled-By : Bob Copeland <[email protected]>

I must admit I still don't have an idea of the root cause on this
one. It still looks like some kind of memory corruption to me,
but no smoking gun so far. The one patch in 2.6.30 that might have
fixed it in the driver didn't help.

Anyway here's a patch to buy some time. Johannes, would this be
an acceptable band-aid for now?

Sergey, can you test this patch? It doesn't fix anything but hopefully
makes your system survive the bug. I gave it a quick test by forcing
one of the rate indexes to a bad value.

From: Bob Copeland <[email protected]>
Date: Mon, 6 Apr 2009 22:04:09 -0400
Subject: [PATCH] mac80211: be more resilient in the face of bad rate indexes

If for whatever reason the rate tables contain invalid rates,
ieee80211_get_tx_rate will warn and return NULL, causing some
drivers to crash. Those that don't will subsequently hit a
BUG_ON() in rate.c. Instead, return a valid rate structure from
ieee80211_get_tx_rate() and only WARN() in rate_control_get_rate().

Signed-off-by: Bob Copeland <[email protected]>
---
include/net/mac80211.h | 12 +++++++++---
net/mac80211/rate.c | 2 +-
2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 3b83a80..4a74f40 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -1014,13 +1014,19 @@ static inline void SET_IEEE80211_PERM_ADDR(struct ieee80211_hw *hw, u8 *addr)
memcpy(hw->wiphy->perm_addr, addr, ETH_ALEN);
}

+static inline s8
+rate_lowest_index(struct ieee80211_supported_band *sband,
+ struct ieee80211_sta *sta);
+
static inline struct ieee80211_rate *
ieee80211_get_tx_rate(const struct ieee80211_hw *hw,
const struct ieee80211_tx_info *c)
{
- if (WARN_ON(c->control.rates[0].idx < 0))
- return NULL;
- return &hw->wiphy->bands[c->band]->bitrates[c->control.rates[0].idx];
+ s8 idx = c->control.rates[0].idx;
+ if (WARN_ON(idx < 0))
+ idx = rate_lowest_index(hw->wiphy->bands[c->band],
+ c->control.sta);
+ return &hw->wiphy->bands[c->band]->bitrates[idx];
}

static inline struct ieee80211_rate *
diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
index 4641f00..d8a5d46 100644
--- a/net/mac80211/rate.c
+++ b/net/mac80211/rate.c
@@ -238,7 +238,7 @@ void rate_control_get_rate(struct ieee80211_sub_if_data *sdata,
sdata->max_ratectrl_rateidx);
}

- BUG_ON(info->control.rates[0].idx < 0);
+ WARN_ON(info->control.rates[0].idx < 0);
}

struct rate_control_ref *rate_control_get(struct rate_control_ref *ref)
--
1.6.0.6

--
Bob Copeland %% http://www.bobcopeland.com

2009-04-07 12:57:56

by Johannes Berg

[permalink] [raw]

Subject: Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

> Anyway here's a patch to buy some time. Johannes, would this be
> an acceptable band-aid for now?

This is going to make it print two warnings for one occurrence of the
problem though. I'd much prefer to put something into minstrel.c to
catch when _it_ returns bogus values and in that case return 0, that way
at least the bandaid is restricted to the code it patches up.

johannes

Attachments:

signature.asc (836.00 B)
This is a digitally signed message part

2009-04-07 21:28:20

by Rafael J. Wysocki

[permalink] [raw]

Subject: Re: [Bug #12870] 2.6.29-rc "TKIP: replay detected" regression

On Tuesday 07 April 2009, Hugh Dickins wrote:
> On Mon, 6 Apr 2009, Rafael J. Wysocki wrote:
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12870
> > Subject : 2.6.29-rc "TKIP: replay detected" regression
> > Submitter : Hugh Dickins <[email protected]>
> > Date : 2009-03-11 12:07 (27 days old)
> > References : http://marc.info/?l=linux-kernel&m=123677337219148&w=4
> > Handled-By : "John W. Linville" <[email protected]>
> > Patch : http://marc.info/?l=linux-wireless&m=123678463704691&w=2
>
> John's fix went into 2.6.29 final: please remove this regression now.

Done.

Thanks,
Rafael

2009-04-08 00:49:44

by Bob Copeland

[permalink] [raw]

Subject: Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

On Tue, Apr 07, 2009 at 12:03:45PM +0200, Johannes Berg wrote:
>
> > Anyway here's a patch to buy some time. Johannes, would this be
> > an acceptable band-aid for now?
>
> This is going to make it print two warnings for one occurrence of the
> problem though. I'd much prefer to put something into minstrel.c to
> catch when _it_ returns bogus values and in that case return 0, that way
> at least the bandaid is restricted to the code it patches up.

Ok, then maybe something like this?

I think this covers most of the bases: if the driver is returning crap or
the ->cb gets corrupted, it'll get caught in tx_status. If minstrel
stuffs a -1 in the first slot for any other reason we'll get a warning
before get_tx_rate and a hopefully valid index gets substituted.

diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
index 3824990..1cf7152 100644
--- a/net/mac80211/rc80211_minstrel.c
+++ b/net/mac80211/rc80211_minstrel.c
@@ -181,6 +181,11 @@ minstrel_tx_status(void *priv, struct ieee80211_supported_band *sband,
if (ar[i].idx < 0)
break;

+ if (WARN(ar[i].idx >= mi->n_rates,
+ "minstrel: invalid rate report %d (n=%d)\n",
+ ar[i].idx, mi->n_rates))
+ break;
+
ndx = rix_to_ndx(mi, ar[i].idx);
mi->r[ndx].attempts += ar[i].count;

@@ -328,7 +333,7 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
ar[0].count = mp->max_retry;
ar[1].idx = mi->lowest_rix;
ar[1].count = mp->max_retry;
- return;
+ goto done;
}

/* MRR setup */
@@ -346,6 +351,10 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
ar[i].idx = mi->r[mrr_ndx[i - 1]].rix;
ar[i].count = mi->r[mrr_ndx[i - 1]].adjusted_retry_count;
}
+
+done:
+ if (WARN_ON(ar[0].idx < 0))
+ ar[0].idx = rate_lowest_index(sband, sta);
}

--
Bob Copeland %% http://www.bobcopeland.com

2009-04-08 00:55:30

by Johannes Berg

[permalink] [raw]

Subject: Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

On Tue, 2009-04-07 at 20:46 -0400, Bob Copeland wrote:
> On Tue, Apr 07, 2009 at 12:03:45PM +0200, Johannes Berg wrote:
> >
> > > Anyway here's a patch to buy some time. Johannes, would this be
> > > an acceptable band-aid for now?
> >
> > This is going to make it print two warnings for one occurrence of the
> > problem though. I'd much prefer to put something into minstrel.c to
> > catch when _it_ returns bogus values and in that case return 0, that way
> > at least the bandaid is restricted to the code it patches up.
>
> Ok, then maybe something like this?
>
> I think this covers most of the bases: if the driver is returning crap or
> the ->cb gets corrupted, it'll get caught in tx_status. If minstrel
> stuffs a -1 in the first slot for any other reason we'll get a warning
> before get_tx_rate and a hopefully valid index gets substituted.

Yeah, that looks nicer, thanks.

> diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
> index 3824990..1cf7152 100644
> --- a/net/mac80211/rc80211_minstrel.c
> +++ b/net/mac80211/rc80211_minstrel.c
> @@ -181,6 +181,11 @@ minstrel_tx_status(void *priv, struct ieee80211_supported_band *sband,
> if (ar[i].idx < 0)
> break;
>
> + if (WARN(ar[i].idx >= mi->n_rates,
> + "minstrel: invalid rate report %d (n=%d)\n",
> + ar[i].idx, mi->n_rates))
> + break;

It might be easier to print this in hex -- that way things like 0x6b are
more apparent?

johannes

Attachments:

signature.asc (836.00 B)
This is a digitally signed message part