2023-10-09 15:36:18

by Bartosz Golaszewski

Subject: [PATCH v3 02/15] firmware: qcom: scm: add a missing forward declaration for struct device

From: Bartosz Golaszewski <[email protected]>

We reference struct device in the private scm header but we neither
include linux/device.h nor forward declare it. Fix it.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/firmware/qcom/qcom_scm.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h
index 7b68fa820495..c88e29051d20 100644
--- a/drivers/firmware/qcom/qcom_scm.h
+++ b/drivers/firmware/qcom/qcom_scm.h
@@ -4,6 +4,8 @@
#ifndef __QCOM_SCM_INT_H
#define __QCOM_SCM_INT_H

+struct device;
+
enum qcom_scm_convention {
SMC_CONVENTION_UNKNOWN,
SMC_CONVENTION_LEGACY,
--
2.39.2

2023-10-10 19:46:47

by Andrew Halaney

Subject: Re: [PATCH v3 02/15] firmware: qcom: scm: add a missing forward declaration for struct device

On Mon, Oct 09, 2023 at 05:34:14PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> We reference struct device in the private scm header but we neither
> include linux/device.h nor forward declare it. Fix it.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Andrew Halaney <[email protected]>