Hi Djakov,
Georgi Djakov <georgi.djakov <at> linaro.org> writes:
>
> In the current parent mapping code, we can get duplicate or
inconsistent
> indexes, which leads to discrepancy between the number of elements in
the
> array and the number of parents. Until now, this was solved with some
> reordering but this is not always possible.
>
> This patch introduces index tables that are used to define the
relations
> between the PLL source and the hardware mux configuration value.
> To accomplish this, here we do the following:
There are other functions using f->src as index directly to find the
parent clock, at least the followings in file clk-rcg2.c:
clk_pixel_determine_rate()
_freq_tbl_determine_rate()
clk_pixel_set_rate()
clk_edp_pixel_determine_rate()
clk_byte_determine_rate()
Shall we convert the index using qcom_find_src_index() at all these
places?
Thanks,
Hai
On 1.04.15 17:22, Hai Li wrote:
> Hi Djakov,
>
> Georgi Djakov <georgi.djakov <at> linaro.org> writes:
>
>>
>> In the current parent mapping code, we can get duplicate or
> inconsistent
>> indexes, which leads to discrepancy between the number of elements in
> the
>> array and the number of parents. Until now, this was solved with some
>> reordering but this is not always possible.
>>
>> This patch introduces index tables that are used to define the
> relations
>> between the PLL source and the hardware mux configuration value.
>> To accomplish this, here we do the following:
>
>
> There are other functions using f->src as index directly to find the
> parent clock, at least the followings in file clk-rcg2.c:
> clk_pixel_determine_rate()
> _freq_tbl_determine_rate()
> clk_pixel_set_rate()
> clk_edp_pixel_determine_rate()
> clk_byte_determine_rate()
>
> Shall we convert the index using qcom_find_src_index() at all these
> places?
>
Hi,
Yes, thanks for reporting this. I am working on a fix and trying
to verify it on all the platforms.
BR,
Georgi